514053 - when there's only one tab in the tab bar, Close Tab entry should read Close Window with default setting when browser.tabs.closeWindowWithLastTab = true

Status: NEW

(Firefox :: Menus, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Like the summary says: when there's only one tab in the tab bar, Close Tab entry on the context and menubar should read Close Window with default setting when browser.tabs.closeWindowWithLastTab = true to help users understand that the tab, at that point, is the window.

When browser.tabs.closeWindowWithLastTab = false, it should stay as "Close Tab"

Comment 1

[Dão Gottwald [:dao]]

Really? That would be two Close Window items in the File menu.

Comment 2

[eyal gruss]

if firefox 3.7 will have the rigid home-tab on the left this issue would become invalid anyway.

Comment 3

[Armin Fuerst]

I think, closing the last tab should clear the tab - as it used to be in FF 3.0.

Comment 4

[Michael Kohler [:mkohler]]

IMO the context entry should read "Close Window" and the entry in the File menu should be hidden when browser.tabs.closeWindowWithLastTab = false. If you come up with a decision, I can make a patch.

Comment 5

[Michael Kohler [:mkohler]]

Mike, Alex: what's on your mind about this one year later?

Comment 6

[Armin Fuerst]

(In reply to comment #5)
> Mike, Alex: what's on your mind about this one year later?
You didn't ask me, but I'm still annoyed by the new behavior. I'd still prefer to have the possibility for the "old" behavior (until FF 3.0).

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

If the tab close button is removed from the single remaining tab (or Firefox is open with only app tabs remaining), then the Close Tab entry in the File menu should be disabled.

(The caveat is that I believe that the close button should not be removed, adn closing the last normal tab should close the window, but beltzner and I disagree on this)

Comment 8

[eyal gruss]

alex: why disable close tab in the file menu for app tabs? they are still closable via their context menu

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

yeah that should be fine, we need to make sure that accel-w doesn't close app tabs though, since they should be as hard to get rid of as they are to create.

Comment 10

[Michael Kohler [:mkohler]]

Thanks for this information. I'll try to come up with a patch.