Closed Bug 514151 Opened 13 years ago Closed 13 years ago
Spelling dictionary names not human readable on Linux
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:188.8.131.52) Gecko/2009080316 Ubuntu/8.10 (intrepid) Firefox/3.0.13 Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:184.108.40.206) Gecko/2009080316 Ubuntu/8.10 (intrepid) Firefox/3.0.13 It seems that the code for finding spelling dictionaries in inlineSpellCheckUI.js expects nonstandard dictionary names. On Linux, most spelling dictionaries have a file name like lc_RC where lc = language code (e.g. "en") and RC = region code (e.g. "US"), separated by an underscore. By contrast, Mozilla expects the separator to be a hyphen. On a Fedora 12 alpha Live CD, when you install hunspell-en (the dictionary pack for English for hunspell) you get a language menu with unreadable computer-ish names like "en_GB" and "en_US". On Windows (and Debian, because they have a workaround in place), you get human-readable names like "English / United Kingdom" and "English / United States" in the spelling dictionary language menu. Reproducible: Always Steps to Reproduce: 1. Navigate to a page with a <textarea> or other spell-checkable element 2. Type in some typos 3. Right-click in the textarea, and inspect the Languages > submenu in the menu you got when you right-clicked Actual Results: en_AU en_ZA en_GB en_US Expected Results: English / Australia English / South Africa English / United Kingdom English / United States https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/66015 is a related Ubuntu bug which has lots of triage notes (and also a fair amount of noise). Note that Ubuntu inherited the Debian workaround, which has a problem (which is really the topic of the Ubuntu bug in question): it displays *both* the underscored names and the human-readable names.
This is supposed to be done by the fix in bug 335600 - why doesn't it work on Linux ?
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/ shows en-US. So, do we need to support both '_' and '-' as separators?
Severity: trivial → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Support both separators using a regex.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #409292 - Flags: review?(gavin.sharp)
Attachment #409292 - Flags: review?(gavin.sharp) → review+
+1 Dunno if I'm allowed to say that here but that seems like an elegant and unintrusive fix.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 409292 [details] [diff] [review] patch - v1 Ubuntu and other Linux distros would appreciate this fix being backported, as it fixes a very ugly UI eye sore.
Attachment #409292 - Flags: approval220.127.116.11? → approval18.104.22.168?
It only fixes half of the issue though. The duplicates still show up.
(In reply to comment #8) > It only fixes half of the issue though. The duplicates still show up. Isn't that easily fixable on your end by removing the hack (symlinks) you've used for years for this?
FWIW, the file to which the patch - v1 applies doesn't exist in older releases. This patch applies to the right file on these older releases.
(In reply to comment #9) > Isn't that easily fixable on your end by removing the hack (symlinks) you've > used for years for this? I really don't know where they come from, though. I certainly didn't add them myself as I'm not the dictionary maintainer, and I don't recall requesting them... I would happily have fixed the current bug if I had known these links were being added especially for mozilla products, which seem to be the case. So yes, removing the symlinks is the fix. I'm still puzzled why they got there, though.
(In reply to comment #8) > It only fixes half of the issue though. The duplicates still show up. I filed Bug 528831 to address that issue.
FWIW Mike Hommey opened a bug on the Debian side about the now-redundant symlinks: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=557604
Comment on attachment 409292 [details] [diff] [review] patch - v1 a192=beltzner
Attachment #409292 - Flags: approval1.9.2? → approval1.9.2+
Attachment #409292 - Flags: approval22.214.171.124? → approval126.96.36.199-
Comment on attachment 414001 [details] [diff] [review] patch for 1.9.1 Approved for 188.8.131.52, a=dveditz for release-drivers
Attachment #414001 - Flags: approval184.108.40.206+
You need to log in before you can comment on or make changes to this bug.