514407 - Make cache file writes asynchronous

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Down with synchronous non-critical IO during startup!

The current sync implementation can also result in Fun Times on slow media after managing engines or installing new ones since we write the full file out every time we invalidate the cache.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 398369 [details] [diff] [review]
Patch

http://reviews.visophyte.org/r/398369/

on file: toolkit/components/search/nsSearchService.js line 224
> __defineGetter__("NetUtil", function() {
>   delete this.NetUtil;
>   Components.utils.import("resource://gre/modules/NetUtil.jsm");
>   return NetUtil;
> });

Use XPCOMUtils.defineLazyGetter please.


on file: toolkit/components/search/nsSearchService.js line 825
>   var templateURI = NetUtil.newURI(aTemplate);

:)

r=sdwilsh

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 398369 [details] [diff] [review]
Patch

>diff --git a/toolkit/components/search/nsSearchService.js b/toolkit/components/search/nsSearchService.js

>+      NetUtil.asyncCopy(data, ostream, function(rv) {
>+        if (!Components.isSuccessCode(rv))
>+          throw Components.Exception("failure during asyncCopy", rv);

LOG here, as well?

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/rev/c65c4fbf96fd

(In reply to comment #1)
> Use XPCOMUtils.defineLazyGetter please.

The search service doesn't use/import XPCOMUtils and I don't want to take the import hit until we have more stuff using it (bug 386473) - but noted!

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/rev/7c7654971790

s/NetUtil.newURI/makeURI/ due to throw-happiness - it'd be nice to have it return null instead.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed based on check-in and follow-up fix.