Closed
Bug 514416
Opened 16 years ago
Closed 16 years ago
Context menu displays incorrectly after resizing address toolbar
Categories
(SeaMonkey :: MailNews: Composition, defect)
SeaMonkey
MailNews: Composition
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: fixed-seamonkey2.0, regression)
Attachments
(1 file)
|
1.54 KB,
patch
|
mnyromyr
:
review+
iannbugzilla
:
approval-seamonkey2.0+
|
Details | Diff | Splinter Review |
Possibly due to the intervening popup manager rewrite, the compose context menu does not display correctly after the address toolbar is resized, because the splitter code (uselessly) sets height="0" on all the popups.
|
Assignee | |
Comment 1•16 years ago
|
||
I also spotted a -moz-collapsed tweak caused by bug 506492.
|
||
Comment 2•16 years ago
|
||
Comment on attachment 398383 [details] [diff] [review]
Proposed patch
>diff -r 81f27df7d581 suite/mailnews/compose/addressingWidgetOverlay.js
>+function awSizerResized(splitter)
aSplitter ;-)
>+ for (var sib = splitter.previousSibling; sib; sib = sib.previousSibling)
Please use let for subscope variables.
>diff -r 81f27df7d581 suite/mailnews/compose/messengercompose.xul
> <splitter id="compose-toolbar-sizer" resizeafter="grow"
>+ onmousedown="awSizerListen();" oncommand="awSizerResized(this);">
Please use one attribute-per-line style here.
r=me with that.
Attachment #398383 -
Flags: review?(mnyromyr) → review+
Comment on attachment 398383 [details] [diff] [review]
Proposed patch
a=me with review comments addresses
Attachment #398383 -
Flags: approval-seamonkey2.0+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed changeset 25b3a9e27c15 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Keywords: fixed-seamonkey2.0
Target Milestone: --- → seamonkey2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•