514491 - In a save as dialog, the extension of the file name to save as should change along with the filter [MAC]

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Rain [:rain1] (inactive)]

STR:

1. In Firefox, right click -> Save Page As...
2. Notice that the file name ends in .html (e.g. Google.html).
3. Change the "Save As" format to Text Files.

The file name should change to Google.txt, but doesn't.

According to smichaud on #macdev, this is a regression from the 2.0.0.x days.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

The same thing happens on Windows and Linux, so -> All.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Though (on Windows, if I remember correctly) it doesn't happen on Vista or Windows 7 -- only on Windows XP.

Comment 3

[Rain [:rain1] (inactive)]

I've filed separate bugs for XP and Linux -- bug 514493 for Linux and bug 514494 for XP. Could we please keep this Mac only? If they turn out to have the same underlying cause then one can be duped to the other.

Comment 4

[Thomas D. (:thomas8)]

Let's be a bit more explicit in the summary that this is OS-specific, having multiple bugs for the same issue on different OS is confusing enough...

Comment 5

[Josh Aas]

Attachment: Bug 514491 - macOS: Update file extension when changing the format in the save panel. r?#mac-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46059f257168
https://hg.mozilla.org/integration/autoland/rev/fb3b4fffebdc
macOS: Update file extension when changing the format in the save panel. r=mac-reviewers,bradwerth

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fb3b4fffebdc