Closed Bug 514787 Opened 10 years ago Closed 10 years ago

Remove unused TARGET_CARBON and TARGET_API_MAC_CARBON in configure.in

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: xfsunoles, Assigned: xfsunoles)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

TARGET_CARBON was Used on old OS 9
Occurring to mxr search, TARGET_API_MAC_CARBON is still uses in freetype2. There is no reasons for that.
I'm sure it doesn't break anything. :)
Assignee: nobody → xfsunoles
Status: NEW → ASSIGNED
Attachment #398791 - Flags: superreview?(ted.mielczarek)
Attachment #398791 - Flags: review?(ted.mielczarek)
Comment on attachment 398791 [details] [diff] [review]
Tell it so
[Checkin: Comment 3]

You don't need sr here.
Attachment #398791 - Flags: superreview?(ted.mielczarek)
Attachment #398791 - Flags: review?(ted.mielczarek)
Attachment #398791 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/5339f85c3e22
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Attachment #426716 - Flags: superreview?(bugzilla)
Attachment #426716 - Flags: review?(bugzilla)
Flags: in-testsuite-
Attachment #426717 - Flags: review? → review?(benjamin)
Comment on attachment 426716 [details] [diff] [review]
(Bv1-CC) Remove them from comm-central too
[Moved to bug 556269]

Serge, please put this in a mailnews specific bug, so that we can properly search and track fixes going into comm-central and not hijack core bugs.
Attachment #426716 - Flags: superreview?(bugzilla)
Attachment #426716 - Flags: review?(bugzilla)
Attachment #426716 - Flags: superreview?(bugzilla)
Attachment #426716 - Flags: review?(bugzilla)
Attachment #426717 - Flags: review?(benjamin) → review+
Comment on attachment 426717 [details] [diff] [review]
(Cv1) Update nsILocalFileMac.idl too
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/d00e19e65db5
Attachment #426717 - Attachment description: (Cv1) Update nsILocalFileMac.idl too → (Cv1) Update nsILocalFileMac.idl too [Checkin: Comment 7]
Attachment #398791 - Attachment description: Tell it so → Tell it so [Checkin: Comment 3]
(In reply to comment #4)
> Created an attachment (id=426716) [details]
> (Bv1-CC) Remove them from comm-central too

Can you build Thunderbird successfully with this patch? The removal of the AC_DEFINEs in configure.in is unproblematic, I do this for a few month now. But if I also patch nsMsgAppleEncode.cpp, than I get:
/mailnews/compose/src/nsMsgAppleEncode.cpp:182: error: ‘GetWDInfo’ was not declared in this scope
if I build in i386. I have no idea why...
I was googling for "GetWDInfo", it show it is not supported in Mac OS X and Carbon. Maybe somebody has a better idea for it.
Comment on attachment 426716 [details] [diff] [review]
(Bv1-CC) Remove them from comm-central too
[Moved to bug 556269]

Per comment 8 this gives a compilation error which obviously needs resolving in the mailnews code. Therefore please spin this to a separate bug with the patch and the current errors, then we can come up with a solution there.
Attachment #426716 - Flags: superreview?(bugzilla)
Attachment #426716 - Flags: superreview-
Attachment #426716 - Flags: review?(bugzilla)
Attachment #426716 - Flags: review-
(In reply to comment #10)
> (From update of attachment 426716 [details] [diff] [review])
> Therefore please spin this to a separate bug with the patch
> and the current errors, then we can come up with a solution there.
Bug 555684
Blocks: 555684
No longer blocks: C192ConfSync
No longer blocks: 555684
(In reply to comment #10)
> spin this to a separate bug with the patch

I filed bug 556269.
Attachment #426716 - Attachment description: (Bv1-CC) Remove them from comm-central too → (Bv1-CC) Remove them from comm-central too [Moved to bug 556269]
Attachment #426716 - Attachment is obsolete: true
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.