514787 - Remove unused TARGET_CARBON and TARGET_API_MAC_CARBON in configure.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jonathan Steele]

TARGET_CARBON was Used on old OS 9
Occurring to mxr search, TARGET_API_MAC_CARBON is still uses in freetype2. There is no reasons for that.

Comment 1

[Jonathan Steele]

Attachment: Tell it so [Checkin: Comment 3]

I'm sure it doesn't break anything. :)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 398791 [details] [diff] [review]
Tell it so
[Checkin: Comment 3]

You don't need sr here.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/5339f85c3e22

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Remove them from comm-central too [Moved to bug 556269]

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Update nsILocalFileMac.idl too [Checkin: Comment 7]

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 426716 [details] [diff] [review]
(Bv1-CC) Remove them from comm-central too
[Moved to bug 556269]

Serge, please put this in a mailnews specific bug, so that we can properly search and track fixes going into comm-central and not hijack core bugs.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 426717 [details] [diff] [review]
(Cv1) Update nsILocalFileMac.idl too
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/d00e19e65db5

Comment 8

[Nomis101]

(In reply to comment #4)
> Created an attachment (id=426716) [details]
> (Bv1-CC) Remove them from comm-central too

Can you build Thunderbird successfully with this patch? The removal of the AC_DEFINEs in configure.in is unproblematic, I do this for a few month now. But if I also patch nsMsgAppleEncode.cpp, than I get:
/mailnews/compose/src/nsMsgAppleEncode.cpp:182: error: ‘GetWDInfo’ was not declared in this scope
if I build in i386. I have no idea why...

Comment 9

[Jonathan Steele]

I was googling for "GetWDInfo", it show it is not supported in Mac OS X and Carbon. Maybe somebody has a better idea for it.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 426716 [details] [diff] [review]
(Bv1-CC) Remove them from comm-central too
[Moved to bug 556269]

Per comment 8 this gives a compilation error which obviously needs resolving in the mailnews code. Therefore please spin this to a separate bug with the patch and the current errors, then we can come up with a solution there.

Comment 11

[Nomis101]

(In reply to comment #10)
> (From update of attachment 426716 [details] [diff] [review])
> Therefore please spin this to a separate bug with the patch
> and the current errors, then we can come up with a solution there.
Bug 555684

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> spin this to a separate bug with the patch

I filed bug 556269.