Closed
Bug 514818
Opened 16 years ago
Closed 16 years ago
work around bug 514817 in Fennec (aboutRights broken in branded builds)
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0b4
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 1 obsolete file)
7.75 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•16 years ago
|
||
This copies the DTD, and makes the one change indicated by the l10n note: removes the specific references to the pref pane for disabling in favor of a generic "in application preferences".
We can probably remove all references to this safebrowsing text entirely, since we don't have it enabled, but I'm leaving it in for now to play it safe.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•16 years ago
|
||
> We can probably remove all references to this safebrowsing text entirely, since
> we don't have it enabled, but I'm leaving it in for now to play it safe.
bug 514822.
Updated•16 years ago
|
Attachment #398826 -
Flags: review+
Comment 3•16 years ago
|
||
Comment on attachment 398826 [details] [diff] [review]
patch
>
> @AB_CD@.jar:
> % locale browser @AB_CD@ %locale/@AB_CD@/browser/
> locale/@AB_CD@/browser/about.dtd (%chrome/about.dtd)
>+ locale/@AB_CD@/browser/aboutRightsOverride.dtd (%chrome/aboutRightsOverride.dtd)
> locale/@AB_CD@/browser/browser.dtd (%chrome/browser.dtd)
> locale/@AB_CD@/browser/browser.properties (%chrome/browser.properties)
> locale/@AB_CD@/browser/firstrun.dtd (%chrome/firstrun.dtd)
> locale/@AB_CD@/browser/search.properties (%chrome/search.properties)
> locale/@AB_CD@/browser/region.properties (%chrome/region.properties)
> locale/@AB_CD@/browser/preferences.dtd (%chrome/preferences.dtd)
> locale/@AB_CD@/browser/checkbox.dtd (%chrome/checkbox.dtd)
> locale/@AB_CD@/browser/notification.dtd (%chrome/notification.dtd)
> locale/@AB_CD@/browser/prompt.dtd (%chrome/prompt.dtd)
> # Fennec-specific overrides of generic strings
> * locale/@AB_CD@/browser/netError.dtd (%chrome/overrides/netError.dtd)
Move the aboutRightsOverride.dtd to the "overrides" folder with the netError.dtd and rename it to just aboutRights.dtd
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #398826 -
Attachment is obsolete: true
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → B4
Comment 6•16 years ago
|
||
this'll need to be verified on b4 release
Comment 7•16 years ago
|
||
verified FIXED on build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091001 Fennec/1.0b4
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•