514818 - work around bug 514817 in Fennec (aboutRights broken in branded builds)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This copies the DTD, and makes the one change indicated by the l10n note: removes the specific references to the pref pane for disabling in favor of a generic "in application preferences".

We can probably remove all references to this safebrowsing text entirely, since we don't have it enabled, but I'm leaving it in for now to play it safe.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

> We can probably remove all references to this safebrowsing text entirely, since
> we don't have it enabled, but I'm leaving it in for now to play it safe.

bug 514822.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 398826 [details] [diff] [review]
patch

> 
> @AB_CD@.jar:
> % locale browser @AB_CD@ %locale/@AB_CD@/browser/
>   locale/@AB_CD@/browser/about.dtd                (%chrome/about.dtd)
>+  locale/@AB_CD@/browser/aboutRightsOverride.dtd  (%chrome/aboutRightsOverride.dtd)
>   locale/@AB_CD@/browser/browser.dtd              (%chrome/browser.dtd)
>   locale/@AB_CD@/browser/browser.properties       (%chrome/browser.properties)
>   locale/@AB_CD@/browser/firstrun.dtd             (%chrome/firstrun.dtd)
>   locale/@AB_CD@/browser/search.properties        (%chrome/search.properties)
>   locale/@AB_CD@/browser/region.properties        (%chrome/region.properties)
>   locale/@AB_CD@/browser/preferences.dtd          (%chrome/preferences.dtd)
>   locale/@AB_CD@/browser/checkbox.dtd             (%chrome/checkbox.dtd)
>   locale/@AB_CD@/browser/notification.dtd         (%chrome/notification.dtd)
>   locale/@AB_CD@/browser/prompt.dtd               (%chrome/prompt.dtd)
> # Fennec-specific overrides of generic strings
> * locale/@AB_CD@/browser/netError.dtd             (%chrome/overrides/netError.dtd)

Move the aboutRightsOverride.dtd to the "overrides" folder with the netError.dtd and rename it to just aboutRights.dtd

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/53bc425ee331

Comment 6

[Aakash Desai [:aakashd]]

this'll need to be verified on b4 release

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091001 Fennec/1.0b4