514850 - Ignore contents of forwarded mail that lacked attachment in attachment detection

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[:Gijs (he/him)]

STR:
1. Obtain reservation email from Eurostar.
2. Forward to parents so they know when you're travelling. Add a tiny tidbit in Dutch with no mentions of attachments or anything:

Zie hier de boeking van mijn Eurostar. Ik zal dan vanuit Brussel de internationale trein pakken. Ik zal dan zo rond 10 uur 's avonds op station Apeldoorn moeten zijn, als ik alles gewoon haal enzo...

Groeten,
Gijs

3. Hit send.

Expected:
Email is sent normally.

Actual result:
Did you forget to add an attachment?


----
I'm guessing the detection was triggered by the contents of the forwarded mail, which contained:

"You may be able to make changes to your booking online via our Manage your booking feature (please refer to the original terms and conditions attached to your ticket)."


I don't think the contents of the forwarded mail should count, unless perhaps the original email had an attachment and it's not being forwarded (if that can happen, haven't tried).

Comment 1

[rsx11m]

This should be similar to bug 282278 for the spell checker. That solution worked for HTML messages only though, by identifying the header table.

Comment 3

[[e-mail]]

Flagging as blocking, since this is a new feature, and it should work properly before release.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

We'd love it, but if this were the last one blocking we wouldn't hold for this.  Assigning to Blake in case he has extra bandwidth between now and the time we ship.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to ignore forwarded messages.

Instead of trying to do something like the fix for bug 282278, I went for something more like the fix for bug 511417.

Later,
Blake.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 407343 [details] [diff] [review]
A patch to ignore forwarded messages.

Nice! r=mkmelin and a-tb3 too, this should be safe

Comment 7

[Mark Banner (:standard8)]

Checked in:
http://hg.mozilla.org/comm-central/rev/0dbeb900459f
http://hg.mozilla.org/releases/comm-1.9.1/rev/2c4cb164e5bf