514854 - Default theme issues with some menulists

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Ian Neal]

At the moment there are a few issues with some menulists when you are using the default theme:
On Linux:
1/ In the Browser Preferences pane, the Display on menulist has its label truncated.

On all platforms (well at least linux and windows):
1/ The Browser > Internet Search Preferences pane, can have truncated labels when selected(e.g. dmoz.org).
2/ On the same pane (comparing to modern theme) the menuitems are missing icons.
3/ In Composer, on Insert Image > Appearance > Align Text to image, some have truncated labels when selected (e.g. Wrap to the left).
4/ In the same place (comparing to modern theme) the menuitems are missing icons.

Comment 1

[Ian Neal]

Attachment: Override display:none for insert image in composer patch v0.1

This patch:
* Overrides the display:none so that icons get displayed in the "Align Text to image" menulist.

Comment 2

[Ian Neal]

Attachment: Fix default theme menulist issues in SM patch v0.1

This patch:
* Overrides display:none for engines in internet search preferences.
* Fixes issue with Browser Startup being in bold on linux.

Comment 3

[Stefan [:stefanh]]

Maybe you could do this in a seamonkey platform file like communicator.css?

Comment 4

[[e-mail]]

Comment on attachment 398861 [details] [diff] [review]
Override display:none for insert image in composer patch v0.1

>+.align-menu > .menu-iconic-left {
>+  display: -moz-box !important;
The !important doesn't seem to be necessary.

It would be a good idea if you reset the width and height on the inner .menu-iconic-icon too.

Comment 5

[[e-mail]]

Comment on attachment 398862 [details] [diff] [review]
Fix default theme menulist issues in SM patch v0.1

IHMO if you're going to fix toolkit so that you can request images on menuitems then a .menuitem-iconic class is probably the way to go.

[Bug 514883 was filed on gnomestripe groupbox captions.]

Comment 6

[Ian Neal]

Attachment: Fix using menuitem-iconic patch v0.2

This patch takes suggested approach:
* Adds menuitem-iconic classes to pref-search.xul and EdImageOverlay.xul menuitems.
* Adds entry to communicator.css for win/*nix to override display:none.

Comment 7

[[e-mail]]

Comment on attachment 399125 [details] [diff] [review]
Fix using menuitem-iconic patch v0.2

>+menuitem.menuitem-iconic > .menu-iconic-left {
>+  display: -moz-box !important;
I think you'll find this works without !important. (I don't like using that unnecessarily.)

>+}
>+
>+
Nit: doubled blank line.

Comment 8

[Ian Neal]

Attachment: Fix using menuitem-iconic but no important patch v0.2a [Checkin: Comment 9]

This patch addresses reviewer's comments.
Requesting a= for low risk, polish patch.

Comment 9

[Ian Neal]

Comment on attachment 399283 [details] [diff] [review]
Fix using menuitem-iconic but no important patch v0.2a [Checkin: Comment 9]

http://hg.mozilla.org/comm-central/rev/0163d8c1e7ca