514883 - Groupbox custom caption content has bold font

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[[e-mail]]

It's not uncommon for groupbox captions to contain non-default content. The most popular example is a menulist, which gets used a few times throughout the codebase, most noticeably in font preferences (all three applications). Unfortunately bold menulists look particularly bad as their menuitems are not bold and they therefore fail to size to fit their widest item correctly.

I'd therefore appreciate suggestions as to how to resolve this for gnomestripe. Feel free to suggest other ideas, but three to get you thinking are a) just make menulists use the same font as menuitems b) only apply bold to the default caption label class c) apply bold to any label in a caption.

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> Unfortunately bold menulists look particularly bad as their menuitems are not
> bold and they therefore fail to size to fit their widest item correctly.

This sounds like menulists shouldn't inherit font-weight.

Comment 2

[[e-mail]]

I've had a look at our only in-tree user of a custom <caption> that doesn't use a menulist; this is Venkman's Breakpoint Properties dialog. Its bold checkbox caption does not seem too much out of place.

Comment 3

[[e-mail]]

Attachment: Possible patch

Comment 4

[[e-mail]]

Pushed changeset 0d056cf12c63 to mozilla-central.

I guess I'll call this fixed then.

Comment 5

[Ian Neal]

Comment on attachment 398937 [details] [diff] [review]
Possible patch

Would like to get this fix into SM2.0 and SM2.1 - low risk fix.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 398937 [details] [diff] [review]
Possible patch

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 7

[Ian Neal]

Neil pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/95d4f7e613cc

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 398937 [details] [diff] [review]
Possible patch

a192=beltzner

Comment 9

[[e-mail]]

Pushed changeset 8a96df13cf59 to releases/mozilla-1.9.2

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Is there a way to manually verify this fix?

Comment 11

[[e-mail]]

Sure, just compare font preferences before and after.