Closed Bug 515002 Opened 11 years ago Closed 11 years ago

sync config.guess to latest version from gnu, include Mac 64-bit fix

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

We should sync config.guess to the latest version from gnu and include a fix for this gnu bug I filed:

https://savannah.gnu.org/patch/?6827
Attached patch fix v1.0Splinter Review
Attachment #399029 - Flags: review?(ted.mielczarek)
Without this patch, we have to specify "--target=x86_64-apple-darwin8.0.0" in any 64-bit mozconfig because config.guess gets it wrong and we get build errors.
bsmedberg, cls: do we have any local patches to config.guess, or are we straight from upstream?
We don't have any local patches. The last time we touched config.guess was the last time I synced it, bug 492623, and I removed all Mozilla-specific patches.
Comment on attachment 399029 [details] [diff] [review]
fix v1.0

Ah, right. Then r=me
Attachment #399029 - Flags: review?(ted.mielczarek) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1a44373ccaf6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hm, since a few hours I get the following message if I try to build:
"make[1]: execvp: /temp/src/mozilla/build/autoconf/config.guess: Permission denied"
And my objdir is only named "obj-". Is there now a permission problem with config.guess?
Nomis101: I don't know what that is about. No probs for me or for tinderboxes.
It looks like the recently checked in versions lost their executable bits:

Current:
-rw-r--r--	2009-09-08 14:55 -0400	45785	config.guess
-rw-r--r--	2009-09-08 14:55 -0400	34301	config.sub

Old:
-rwxr-xr-x	2009-05-12 23:47 -0400	46260	config.guess
-rwxr-xr-x	2009-05-12 23:47 -0400	33952	config.sub
Should I just change the permissions and commit again?
Yeah, that should work. If I had actually paid attention I would have noticed in your patch here:
diff --git a/build/autoconf/config.guess b/build/autoconf/config.guess
old mode 100755
new mode 100644
pushed corrected executable bits to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/cc70e75bb02f
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.