51509 - spaces in profile directory in -CreateProfile doesn't work

Status: REOPENED

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Henrik Gemal]

this doesn't work:
mozilla.exe -CreateProfile "gemal c:\program files"
I'd expect this to create the profile directory gemal under "c:\program files" 
but it doesn't.
instead it created the profile directory under "c:\program"

Comment 1

[scottputterman]

reassigning to racham.

Comment 2

[racham]

We need to investigate more into the latest commandLineService services and see 
if we can do anyhting different...or we can introduce a new token like "," to 
separate 2 arguments which then allows us to avoid problems we have seen with 
spaces in the names of profile or profile directory..

Comment 3

[racham]

Doing a mass reassign to Conrad Carlen.

Conrad is going address all current and upcoming profile manager issues. Please
do not hesitate to involve me in any of the issues.

Comment 4

[Conrad Carlen (not reading bugmail)]

Setting milestone. Easy to fix. Any opinions as to the syntax? Right now, the
delimiter between profile name and the profile dir is a space, with the result
you point out. Its awkward because -CreateProfile can have either 1 or 2 args. A
comma separator would work, or an additional arg such as -Dir. Any preference?

Comment 5

[Henrik Gemal]

I think the syntax could be:
-CreateProfile "gemal" "c:\program files\mozusers"

Comment 6

[Conrad Carlen (not reading bugmail)]

Unfortunately, the nsCmdLineService is designed to have only 1 arg per cmd line
switch. Anything else is considered to be part of a list of URLs to open. It
couldn't handle -CreateProfile "gemal" "c:\program files\mozusers" This would
need to be broken up into two args or lumped together as one with the two
components separated by a specified delimiter. If we added an additional arg to
specify the directory, say -ProfileDir, it could be used with -CreateProfile as
well as -installer. It would be nice to specify the dir to which to migrate from
the command line.

Comment 7

[Henrik Gemal]

-CreateProfile "gemal" -ProfileDir "c:\program files\mozusers"
is also very good.

Comment 8

[Conrad Carlen (not reading bugmail)]

-> mozilla0.9

Comment 9

[Conrad Carlen (not reading bugmail)]

-> mozilla1.0

Comment 10

[Grace Bush]

changing QA contact

Comment 11

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 12

[Conrad Carlen (not reading bugmail)]

Moving milestone.

Comment 13

[Marc DVer]

*** Bug 231662 has been marked as a duplicate of this bug. ***

Comment 14

[[e-mail]]

Attachment: Separate out the path into a separate argument

I think the current code that splits the -CreateProfile argument into two strings is a bit of a hack, and by making it work with an optional -profile argument you get all the goodness that -profile supports (e.g. relative paths).

I was considering even adding a -localprofile argument which gives you an override for just the local profile path.

Comment 15

[Benjamin Smedberg]

Comment on attachment 343447 [details] [diff] [review]
Separate out the path into a separate argument

Existing code such as the unit-testing infrastructure relies on the current behavior (I originally changed it in FF0.9 and broke lots of stuff). I agree that the proposed behavior is better.

I would accept a patch to make -createProfile name -profile path work, but the old behavior also needs to keep working.

Comment 16

[Nicholas Nethercote [inactive]]

-CreateProfile no longer exists.

Comment 17

[Benjamin Smedberg]

No? http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#2258 seems to still be present.

Comment 18

[Nicholas Nethercote [inactive]]

> http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.
> cpp#2258 seems to still be present.

My mistake; I did a case-sensitive search for "CreateProfile". Sorry!