515096 - need a weak frame check in nsComboboxControlFrame::HandleRedisplayTextEvent

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

We need a weak frame check in nsComboboxControlFrame::HandleRedisplayTextEvent because flushing could kill us.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: patch v2

Found another place that needs a weakframe check.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 399142 [details] [diff] [review]
patch v2

r=me.  I look forward to the day when we eliminate sink flushes..

Comment 4

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/b473c6b32f2c

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The first of these is showing up in 3.6b3 topcrashes as http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.6b3&query_search=signature&query_type=exact&query=nsIContent%3A%3ASetText%28nsAString_internal%20const%26%2C%20int%29&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsIContent%3A%3ASetText%28nsAString_internal%20const%26%2C%20int%29

Please land on 1.9.2.

Comment 6

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/afd98d2e9977

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://tinderbox.mozilla.org/Firefox3.6-Unittest/
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6-Unittest/1259197158.1259200635.4415.gz

> Build Error Log
> 
>  Skipping 31668 Lines...
> 
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 57}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property '-moz-border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 58}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Error: "gEditItemOverlay is null" {file: "chrome://browser/content/places/bookmarkProperties.xul" line: 1}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Error: "gEditItemOverlay is null" {file: "chrome://browser/content/places/bookmarkProperties.xul" line: 1}]
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Sidebar tree has been loaded
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | The correct visit has been selected
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | The selected node is not bookmarked
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We have a places node selected: www.mozilla.org
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js |  command 'placesCmd_createBookmark' on current selected node is enabled
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | EditItemOverlay is initialized
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We are editing new folder name in folder tree
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We have finished editing folder name in folder tree
> TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Dialog window should not be closed by pressing ESC in folder name textbox
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | End of test:  Bug 491269 - Test that editing folder name in bookmarks properties dialog does not accept the dialog
> Waiting for window activation...
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'zoom'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 90}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Error in parsing value for 'letter-spacing'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 347}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 406}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 44}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 49}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-top-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 53}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property '-moz-border-top-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 54}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 57}]
> TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property '-moz-border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 58}]
> 
> command timed out: 1200 seconds without output, killing pid 4381
> process killed by signal 9
> program finished with exit code -1

Is this a new regression? Or a new random failure?

Comment 8

[Timothy Nikkel (:tnikkel)]

I think it is a new random failure as this has been on m-c for a month with no problems. I was going to file it when the next run went green.

Comment 9

[Timothy Nikkel (:tnikkel)]

Filed bug 531227 for that random failure.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you!