Closed Bug 515675 Opened 12 years ago Closed 3 months ago

Move thread code to threadPane.js and remove messengerdnd.js

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
trivial

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: sgautherie, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.8.1)

Attachments

(1 file)

I verified this file will be obsolete after (in progress) bug 510793 patch A.
Flags: in-testsuite-
Component: Build Config → MailNews: Backend
Component: MailNews: Backend → MailNews: Message Display
Summary: Remove now useless messengerdnd.js → Move thread code to threadPane.js and remove messengerdnd.js

[Approval Request Comment]
Regression caused by (bug #): 510793
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Three functions (CanDropOnFolderTree, DropOnFolderTree and BeginDragFolderTree) are no longer used and the rest are related to the threadPane so should be move to threadPane.js

Assignee: bugzillamozillaorg_serge_20140323 → iann_bugzilla
Attachment #9220963 - Flags: review?(frgrahl)
Attachment #9220963 - Flags: approval-comm-release?
Attachment #9220963 - Flags: approval-comm-esr60?

Comment on attachment 9220963 [details] [diff] [review]
515675-remove-messengerdnd-2539.patch

LGTM

I think the max file limit could probably be lifted but NS_MAX_FILEDESCRIPTOR is still at 128 +1 in :

https://searchfox.org/mozilla-central/source/widget/windows/nsDataObj.cpp#471

For a future bug I see Re: not being translated which is the same for TB but does not sound right when creating a file name

FRG

Attachment #9220963 - Flags: review?(frgrahl)
Attachment #9220963 - Flags: review+
Attachment #9220963 - Flags: approval-comm-release?
Attachment #9220963 - Flags: approval-comm-release+
Attachment #9220963 - Flags: approval-comm-esr60?
Attachment #9220963 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/98c19646a9fe
Move thread code to threadPane.js and remove messengerdnd.js. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.9
Target Milestone: Future → seamonkey 2.88
Blocks: 1720686
Whiteboard: SM2.53.9 → SM2.53.8.1
You need to log in before you can comment on or make changes to this bug.