515733 - [faceted search] split "Top 10 messages out of 400" differently for localization

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

Here's an excerpt from current glodaFacetView.properties :

Currently this phrase is defined as two strings in glodaFacetView.properties:

glodaFacetView.results.message.countLabel=Top #1 #2 out of #3
glodaFacetView.results.message.countLabelMessagePlurals=message;messages

where #2 and/or #4 in the first string is the appropriate form of the second.

The problem with this is that it may be insufficient and forces localizers to work around this insufficiency. We may need to localize e.g. two words around the number or so. 

Because the sentence involves two numbers and it's most probably impossible for it to depend on both of them, I suggest to split it into two strings differently, like this:

firstPartId=Top #1 message ;Top #1 messages 
secondPartId=out of #1;out of #1
groupingId=#1 #2

Here, firstPartId describes the first part of the sentence, and secondPartId describes the second, while groupingId allows to swap these parts.

Also, I'm not quite sure about that, but perhaps these parts should be joined without any spaces inbetween (to allow using other punctuation marks), as is showed in the example.

Comment 1

[Rimas Kudelis [use needinfo to ping]]

sipaq asked me to explain more clearly what the problem is. :)

The problem is that in the phrase "Top 10 messages" some localizations may need to localize both words "Top" and "messages". This is impossible ATM.

Comment 2

[Rimas Kudelis [use needinfo to ping]]

Uh, sorry for bugspam, but another potential problem in the current situation just hit me:
If I were to use both #2 and #4 arguments in Lithuanian translation, I would need to use different cases of the word "message", and that is currently impossible. And I'm sure that's the same in many other languages.

The suggested scheme of splitting the sentence into two parts solves this problem too.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attachment: improve count label pluralization v1

This patch does as Rimas proposes.  Thank you for the suggestion on how to do this!

This is definitely not backwards compatible...

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 399930 [details] [diff] [review]
improve count label pluralization v1

ugh, I am seeing complaints from PluralForm.jsm.  I am not crazy about PluralForm.jsm.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Attachment: improve the pluralization but don't get fancy with the en-US strings

This should probably be rc1 given the change after the freeze, etc.

Comment 6

[Simon Paquet [:sipaq]]

I agree, we have two weeks after the b4 release for additional string changes before we freeze strings once and for all. This seems suitable for that period.

Comment 7

[Rimas Kudelis [use needinfo to ping]]

Andrew, thanks for reacting so quickly. I hope other localizers are OK with this scheme.

Comment 8

[David Ascher (:davida)]

Gerv pointed out in MDAT that we may want tweaks to the en-US at least.  His suggestion: 

  "Top" and "out" are redundant. "1-10 of 28" is fine.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 399933 [details] [diff] [review]
improve the pluralization but don't get fancy with the en-US strings

>+# LOCALIZATION NOTE(glodaFacetView.results.message.countLabel):

My only thought here is whether we should be using 

# LOCALIZATION NOTE(glodaFacetView.results.message.countLabel.topMessages,
                    glodaFacetView.results.message.countLabel.outOf,
                    glodaFacetView.results.message.countLabel.grouping):

as it may be better for the existing automated tools. However, it is only a comment so can always be fixed up afterwards. So let's get this in, r=Standard8.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

pushed:
http://hg.mozilla.org/comm-central/rev/f416fec60513

No changes were made to the en-US string or comments.  I think we can make the en-US change at any time, and I would like a ui-review sign-off by clarkbw, especially since I think there was some debate in various venues.