515740 - [faceted search] glodaFacetView.results.message.andNOthers lacks a localization note

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

this string in glodaFacetView lacks a localization note, and is quite unclear without it:

glodaFacetView.results.message.andNOthers=and #1 other;and #1 others

Please add an appropriate note.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: add pluralization to the more label

I think this change is okay in the face of the l10n freeze since it is wholly backwards compatible?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 399895 [details] [diff] [review]
add pluralization to the more label

ugh, this was the wrong bug.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attachment: add a localization note for andNOthers

Sorry about this string not having a localization note out of the gate.

I hope this is safe to commit after the l10n freeze, but am unclear on whether it might upset the tooling even though no string gets changed...

Comment 4

[Simon Paquet [:sipaq]]

I think landing this after the string freeze is safe, but since we're touching a .properties file this should still be handled as a late-l10n bug with the corresponding announcement of the change in mozilla.dev.l10n as outlined in https://developer.mozilla.org/en/Thunderbird_Localization#Breaking_the_string_freeze

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/fa26bf510f6b

I'll be emailing l10n shortly.

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #5)
> I'll be emailing l10n shortly.

Thanks. Great explanation!

Comment 7

[Rimas Kudelis [use needinfo to ping]]

Yeah, thanks Mark!