515860 - [faceted search]: deleting last message in 'view as list' mode gets thread view confused

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[David Ascher (:davida)]

STR:

-gloda search
-click on a message in a conversation
-in the list that opens, select the last message
-hit delete (either the key or the trash icon)

--> the thread display doesn't update properly, and navigation gets somewhat confused.

Comment 1

[David Ascher (:davida)]

Also,undo doesn't work.

Comment 2

[Wayne Mery (:wsmwk)]

perhaps similar to what happens with Search Messages?

Comment 3

[Ludovic Hirlimann [:Usul]]

I get an empty line. you can move up with the mouse and then can't go down anymore. we're missing at list a redraw to get rid of the last line.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: situation immediately after pressing delete.

Confirmed. (The screenshot shows what I see immediately after pressing delete on the 2nd msg)

Undo also doesn't work.

Comment 5

[David :Bienvenu]

taking

Comment 6

[David :Bienvenu]

this is not specific to the last message getting deleted, so I'm going to put this in b4 for now.

Comment 7

[Wayne Mery (:wsmwk)]

interesting. I can't reproduce with today's code, nor Thursday's

Comment 8

[David :Bienvenu]

the underlying issue is that the gloda synthetic view isn't "stalking" the underlying folders. This prevents the delete completed notification from getting sent to the view wrapper and then the underlying view. I think I need to make the reportResults method keep track of the different folders we have hits in, and then make the view stalk those folders. I'm still trying to figure out everything about these gloda synthetic views, so it might take me a little while.

If you have a view open on the folder that gets hits already, this won't be an issue because the folder notification helper will already be tracking that folder.

Comment 9

[David :Bienvenu]

Attachment: fix notications for synthetic views

After spending the afternoon in the weeds, it turns out to be simply that synthetic views have no interested listeners, which meant we skipped the curious one, due to my not anticipating this possibility lo these many weeks ago.

the xpcshell tests all pass with this. Adding some xpcshell tests for the gloda synthetic views would be good...

Comment 10

[David :Bienvenu]

fix pushed