515862 - browser.css can get out of date

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Jesse Ruderman]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090910 Firefox/3.7a1pre

Comment 1

[Jesse Ruderman]

Clobbering fixed it.  My chrome://browser/skin/browser.css got out of date from my browser/themes/pinstripe/browser/browser.css.

--> build config, not a bug in the patch in bug 505699

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I don't understand how this is possible. We rebuild the entirety of the theme any time you rebuild in browser/themes, and there are no dependencies to speak of (chrome stuff is just always rebuilt). Sounds more likely to be some local fluke than an actual problem with the build system.

Comment 3

[Dão Gottwald [:dao]]

Likely because of bug 468011, which would mean this is invalid.

Comment 4

[Jesse Ruderman]

How would that make this bug invalid?

Comment 5

[Dão Gottwald [:dao]]

Because it was an intentional build config change. You shouldn't have to clobber more than once.

Comment 6

[Karl Tomlinson (:karlt)]

Is the bug that old jar files are still used even though they are not intended to be part of the build?

Or that the old jar files are not deleted?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I would expect that nightly users are OK because browser/installer/removed-files.in got updated, but developers with older trees would have an issue (particularly if they're using dist/bin instead of make package and dist/firefox).

Comment 8

[Jesse Ruderman]

I'm using e.g.

~/central/opt-obj/dist/Firefox.app/Contents/MacOS/firefox

Comment 9

[(not currently active) Ted Mielczarek]

Our build system doesn't handle blowing away the app bundle in dist, or blowing away dist/bin if things change significantly. This is why nightly/release builds are clobbers, and sometimes you just have to clobber. Removed-files.in takes care of cleaning up nightly updates, but we will never have anything in the build system that knows how to clean up files that were removed from the build. It's too much work for too little value. You'll just have to clobber on the rare occasion that this happens.