518120 - Lightweight theme not applied to navigation, bookmarks bar

Status: RESOLVED DUPLICATE of bug 515862

(Toolkit :: UI Widgets, defect)

Description

[Johnathan Nightingale [:johnath]]

Attachment: Screenshot of partial persona

Using current trunk and dao's JS snippet to install the lolface persona:

> Components.utils.import("resource://gre/modules/LightweightThemeManager.jsm"); LightweightThemeManager.currentTheme = {id:"2538",name:"LOLFace",dominantColor:"#6b6b6b",textColor:"white",headerURL:"http://getpersonas.com/static/3/8/2538/LOL.png",footerURL:"http://getpersonas.com/static/3/8/2538/LOL2.png"}

I end up with the persona applied to my status bar and a toolbar added by an addon (as well as new toolbars I add via "Customize...") but not to my navigation and bookmarks toolbars. This occurs on new profiles as well. I see the same behaviour using a version of the test page Dao attached in bug 511771 (http://people.mozilla.org/~johnath/tmp/personatest.html).

I'm provisionally assigning this to Dao, though Dave mentioned on IRC that he had a suspicion as to the cause. Please feel free to reassign.

Marking this as blocking since it occurs on new profiles and hence seems to not be just-me?

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: working on win7

wfm on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090922 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Comment 2

[Dão Gottwald [:dao]]

Dave, what's your suspicion?

This isn't a problem for everyone on Mac, is it?

Comment 3

[Markus Stange [:mstange]]

It's not a problem for me.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Dave, what's your suspicion?

I misunderstood the situation when johnath first described it to me. I'm not sure what might be happening now, it works fine for me.

Comment 5

[Dão Gottwald [:dao]]

The screenshot seems to indicate that the background image was applied but the root element doesn't get the lwtheme attribute, which would be a bug in LightweightThemeConsumer.jsm. I still don't see how that could happen, though.

Comment 6

[Markus Stange [:mstange]]

The screenshot also shows that -moz-appearance: none is set on the #nav-bar, but background: none isn't.

Comment 7

[Johnathan Nightingale [:johnath]]

Dao - let me know if there are things you want me to DOM inspect or otherwise check - it's quite reproducible for me, including new profiles.

Comment 8

[Dão Gottwald [:dao]]

Yes, I'd like to know whether the root window element has the lwtheme attribute, and which style rules apply to the navigation toolbar (nav-bar).

Comment 9

[Johnathan Nightingale [:johnath]]

(In reply to comment #8)
> Yes, I'd like to know whether the root window element has the lwtheme
> attribute, and which style rules apply to the navigation toolbar (nav-bar).

#main-window does have lwtheme=true

#nav-bar has these styles applied - http://www.grabup.com/uploads/17a71400105332f3a9204ed7c69b83a2.png (sorry for the external link - I can attach here if you prefer, but this was quicker and I'm rushing off to another thing.)

Comment 10

[Dão Gottwald [:dao]]

Could it be that your browser/themes/pinstripe/browser/browser.css isn't up to date?

Comment 11

[Johnathan Nightingale [:johnath]]

(In reply to comment #10)
> Could it be that your browser/themes/pinstripe/browser/browser.css isn't up to
> date?

Hmm, my tree's up to date - going to blow away my objdir and see if I have any staleness there.

Comment 12

[Dão Gottwald [:dao]]

I suspect this is a duplicate of bug 515862.

Comment 13

[Johnathan Nightingale [:johnath]]

(In reply to comment #12)
> I suspect this is a duplicate of bug 515862.

Yep.