Closed Bug 515966 Opened 11 years ago Closed 11 years ago

Message Filter Dialog menulist missing some icons

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(2 files)

Bug 515256 recently landed on SeaMonkey to give icons to "Filters for" menulist.
This bug will cover the porting of that bug to TB.
Attached image Screenshot
Looks like we have images already, no?
(In reply to comment #1)
> Created an attachment (id=400079) [details]
> Screenshot
> 
> Looks like we have images already, no?

Maybe on Mac but not on other platforms.
This patch:
* Sets attributes on folder menulists so xul can add icons if it wants.
* Enables message filter dialog to show icons in the menupopup (already shows on Mac).
Attachment #403273 - Flags: superreview?(bienvenu)
Attachment #403273 - Flags: review?(bugzilla)
Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

This looks fine to me - as Blake's been touching this code recently I'd like him to take a quick look as well.
Attachment #403273 - Flags: review?(bwinton)
Attachment #403273 - Flags: review?(bugzilla)
Attachment #403273 - Flags: review+
Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

It seems good to me.

My only question would be "How did the Mac show those icons already, and is that code now redundant and removable?"

Thanks,
Blake.
Attachment #403273 - Flags: review?(bwinton) → review+
Attachment #403273 - Flags: superreview?(bienvenu) → superreview+
(In reply to comment #5)
> (From update of attachment 403273 [details] [diff] [review])
> It seems good to me.
> 
> My only question would be "How did the Mac show those icons already, and is
> that code now redundant and removable?"
> 
> Thanks,
> Blake.

For platforms that use qute theme, the menu.css has a "display: none;" entry for the menu-iconic-left class. The theme used by Mac doesn't have that entry, so no need to override it.
Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

Requesting an a= that should add some polish to Message Filter dialog "Filter For" menulist.
Attachment #403273 - Flags: approval-thunderbird3?
Attachment #403273 - Flags: approval-thunderbird3? → approval-thunderbird3+
Attachment #403273 - Attachment description: Add icons to Message Filter For menulist on all platforms patch v0.1 → Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]
Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/a5f70fda3fe1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.