515966 - Message Filter Dialog menulist missing some icons

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ian Neal]

Bug 515256 recently landed on SeaMonkey to give icons to "Filters for" menulist.
This bug will cover the porting of that bug to TB.

Comment 1

[Mark Banner (:standard8)]

Attachment: Screenshot

Looks like we have images already, no?

Comment 2

[Ian Neal]

(In reply to comment #1)
> Created an attachment (id=400079) [details]
> Screenshot
> 
> Looks like we have images already, no?

Maybe on Mac but not on other platforms.

Comment 3

[Ian Neal]

Attachment: Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

This patch:
* Sets attributes on folder menulists so xul can add icons if it wants.
* Enables message filter dialog to show icons in the menupopup (already shows on Mac).

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

This looks fine to me - as Blake's been touching this code recently I'd like him to take a quick look as well.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

It seems good to me.

My only question would be "How did the Mac show those icons already, and is that code now redundant and removable?"

Thanks,
Blake.

Comment 6

[Ian Neal]

(In reply to comment #5)
> (From update of attachment 403273 [details] [diff] [review])
> It seems good to me.
> 
> My only question would be "How did the Mac show those icons already, and is
> that code now redundant and removable?"
> 
> Thanks,
> Blake.

For platforms that use qute theme, the menu.css has a "display: none;" entry for the menu-iconic-left class. The theme used by Mac doesn't have that entry, so no need to override it.

Comment 7

[Ian Neal]

Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

Requesting an a= that should add some polish to Message Filter dialog "Filter For" menulist.

Comment 8

[Ian Neal]

Comment on attachment 403273 [details] [diff] [review]
Add icons to Message Filter For menulist on all platforms patch v0.1 [Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/a5f70fda3fe1