Closed Bug 515971 Opened 13 years ago Closed 12 years ago

[faceted search] Faceted search should be made RTL-friendly

Categories

(Thunderbird :: Search, defect)

defect
Not set
normal

Tracking

(thunderbird3.1 .5-fixed)

VERIFIED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- .5-fixed

People

(Reporter: davida, Assigned: bwinton)

Details

(Keywords: rtl, Whiteboard: [has l10n impact])

Attachments

(1 file)

This is going to take someone who understands RTL'ing XHTML, and should probably wait until we've actually finalized the LTR layout, to avoid wasted effort.
Summary: [faceted search][has l10n impact] Faceted search should be made RTL-friendly → [faceted search] Faceted search should be made RTL-friendly
Whiteboard: [has l10n impact]
Component: Mail Window Front End → Search
QA Contact: front-end → search
Ehsan, it'd be great if you could throw in your input on how we could get the new search results page to work well RTL.  The relevant files are:

http://mxr.mozilla.org/comm-central/find?string=facetView&tree=comm-central&hint=
Do you have some screenshots?

Blake: is this something we can look into some time that you're in the office?
Keywords: rtl
So, we still don't do the date view, cause it's canvas, but this at least makes most everything else work out better.

Ehsan helped me a lot with the patch, so it's probably got an implicit rtl-ui-r=him.

(Philor, please let me know if you don't have the time to review this patch, and I'll find some other sucker^H^H^H^H^H^H friendly developer to review it.  Maybe asuth.  He likes reviewing patches, doesn't he? :)

Thanks,
Blake.
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Attachment #449953 - Flags: ui-review?(clarkbw)
Attachment #449953 - Flags: review?(philringnalda)
Keywords: intl
This is not an internationalization bug.
Keywords: intl
Comment on attachment 449953 [details] [diff] [review]
A patch to rtl-enable most of the faceted search tab.

Looks good.  I'm trying it out now but it feels fine so far.


> .message-subject-group {
>-  padding-left: 2px; /* to lign up the subjects with the "Top N messages out of M" */
>+  -moz-padding-start: 2px; /* to lign up the subjects with the "Top N messages out of M" */
> }

Can you fix that comment typo while you're there
Attachment #449953 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 449953 [details] [diff] [review]
A patch to rtl-enable most of the faceted search tab.

Well, I think I've been old-review-guilt-tripping philor for long enough, so now it's asuth's turn.  ;)

Later,
Blake.
Attachment #449953 - Flags: review?(philringnalda) → review?(bugmail)
Comment on attachment 449953 [details] [diff] [review]
A patch to rtl-enable most of the faceted search tab.

The left/right start/end transitions look right, and the other blocks seem safe because of their constrainty things.
Attachment #449953 - Flags: review?(bugmail) → review+
Checked in as http://hg.mozilla.org/comm-central/rev/f753e2711eed

Thanks,
Blake.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 449953 [details] [diff] [review]
A patch to rtl-enable most of the faceted search tab.

I don't know if we want to take RTL-fixes for 3.1, but I figure it's worth nominating.

Thanks,
Blake.
Attachment #449953 - Flags: approval-thunderbird3.2a1?
Attachment #449953 - Flags: approval-thunderbird3.1.4?
Attachment #449953 - Flags: approval-thunderbird3.1.4? → approval-thunderbird3.1.5?
Do we have any idea how this would affect a) themes, b) extensions if we were to land for 3.1.x branch?
I've been operating under the assumption it's impossible to theme or extend the faceted search UI... at the very least, it's quite hard since you can't XUL overlay an html file...
:asuth, well hard to do with static HTML, sure.  But it should be straightforward enough by inserting elements into the live DOM, no?  Of course, whether anyone is actually doing that is really the question...
(In reply to comment #12)
> :asuth, well hard to do with static HTML, sure.  But it should be
> straightforward enough by inserting elements into the live DOM, no?  Of course,
> whether anyone is actually doing that is really the question...

Well, things are XBL and lots of things are constantly getting created and re-created.  So one would need to manually poke CSS rules into the HTML page after detecting its existence, etc.

In any event, I think I responded from the wrong angle.  There is basically one  extension point that does not require massive hacky extension work: custom gloda attributes marked for faceting.  Those will continue to work with Blake's patch.  In the off-chance someone has done the massive hacky extension work, I would not expect it to break, and if it did, the change-work required would be very small and easily justified given the RTL improvements.
Yes, this sounds like the right trade-off to me as well.
Comment on attachment 449953 [details] [diff] [review]
A patch to rtl-enable most of the faceted search tab.

Ok, you've convinced me, lets go for it for 3.1.5.
Attachment #449953 - Flags: approval-thunderbird3.2a1?
Attachment #449953 - Flags: approval-thunderbird3.1.5?
Attachment #449953 - Flags: approval-thunderbird3.1.5+
(I'm still on the NetBook, so I'm marking it checkin-needed for 3.1.5.)
Keywords: checkin-needed
Checked in to 1.9.2: http://hg.mozilla.org/releases/comm-1.9.2/rev/41a87133b218
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 3.3a1
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; ar; rv:1.9.2.11) Gecko/20101004 Thunderbird/3.1.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.