516080 - change "Help Contents" to "Firefox Help"

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Help Contents isn't a good descriptor of what happens when you run the command since we've replaced it with SUMO.

Get Help is clearer and better.

Comment 1

[Curtis Bartley [:cbartley]]

Taking this bug.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Shaver recommends "Firefox Help".

He's right, too.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That applies to Windows and Linux. We are already using "&BrandShortName; Help" on OS X. That would make it identical.

Comment 5

[Curtis Bartley [:cbartley]]

Attachment: Change "Help Contents" to "Firefox Help" v1

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 400304 [details] [diff] [review]
Change "Help Contents" to "Firefox Help" v1

>diff -r 1ad1932defe6 browser/base/content/baseMenuOverlay.xul

>         <menuitem id="menu_openHelp"
>                   oncommand="openHelpLink('firefox-help')"
>+                  label="&helpContents.label;"
> #ifdef XP_MACOSX
>-                  label="&helpContentsMac.label;"
>                   key="key_openHelpMac"/>
> #else
>-                  label="&helpContents.label;"
>                   accesskey="&helpContents.accesskey;"
>                   key="key_openHelp"/>

Move the accesskey out of the ifdef as well? Doesn't hurt to have it defined on mac (even if it has no effect).

>diff -r 1ad1932defe6 browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd

>-<!ENTITY helpContents.label       "Help Contents">
>+<!ENTITY helpContents.label       "&brandShortName; Help">
> <!ENTITY helpContents.accesskey   "H">

You should rev the entity names here to highlight the change to localizers. productHelp.label/accesskey?

r=me with those addressed.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 400304 [details] [diff] [review]
Change "Help Contents" to "Firefox Help" v1

a192=beltzner

Comment 8

[Curtis Bartley [:cbartley]]

Attachment: Change "Help Contents" to "Firefox Help" v2

(In reply to comment #6)
> (From update of attachment 400304 [details] [diff] [review])
> >diff -r 1ad1932defe6 browser/base/content/baseMenuOverlay.xul
> 
> >         <menuitem id="menu_openHelp"
> >                   oncommand="openHelpLink('firefox-help')"
> >+                  label="&helpContents.label;"
> > #ifdef XP_MACOSX
> >-                  label="&helpContentsMac.label;"
> >                   key="key_openHelpMac"/>
> > #else
> >-                  label="&helpContents.label;"
> >                   accesskey="&helpContents.accesskey;"
> >                   key="key_openHelp"/>
> 
> Move the accesskey out of the ifdef as well? Doesn't hurt to have it defined on
> mac (even if it has no effect).


Done.


> >diff -r 1ad1932defe6 browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd
> 
> >-<!ENTITY helpContents.label       "Help Contents">
> >+<!ENTITY helpContents.label       "&brandShortName; Help">
> > <!ENTITY helpContents.accesskey   "H">
> 
> You should rev the entity names here to highlight the change to localizers.
> productHelp.label/accesskey?


Done.


> r=me with those addressed.

Comment 9

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/3bc5b7b5b671

and

Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/92374467156c

Comment 10

[Tyler Downer [He/Him]]

v with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090915 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20090915053258

Comment 11

[Marcia Knous [:marcia]]

Verified fixed on 1.9.2 using  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b2) Gecko/20091108 Firefox/3.6b2. Checked Win Vista and Win XP as well.

Comment 12

[Chris Ilias [:cilias]]

Forgot to mark this bug as user-doc-complete. The change was actually made in November.
<https://support.mozilla.com/en-US/kb/Menu+Reference#Firefox_Help>