Closed Bug 516080 Opened 12 years ago Closed 12 years ago

change "Help Contents" to "Firefox Help"

Categories

(Firefox :: Menus, defect)

3.6 Branch
x86
Windows NT
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: beltzner, Assigned: cbartley)

References

Details

(Keywords: user-doc-complete, Whiteboard: verified1.9.2)

Attachments

(1 file, 1 obsolete file)

Help Contents isn't a good descriptor of what happens when you run the command since we've replaced it with SUMO.

Get Help is clearer and better.
Taking this bug.
Assignee: nobody → cbartley
Shaver recommends "Firefox Help".

He's right, too.
Assignee: cbartley → nobody
Assignee: nobody → cbartley
That applies to Windows and Linux. We are already using "&BrandShortName; Help" on OS X. That would make it identical.
OS: Windows NT → All
Hardware: x86 → All
OS: All → Windows NT
Hardware: All → x86
Summary: change "Help Contents" to "Get Help" → change "Help Contents" to "Firefox Help"
Duplicate of this bug: 462011
Attachment #400304 - Flags: review?(gavin.sharp)
Attachment #400304 - Flags: review?(gavin.sharp) → review+
Comment on attachment 400304 [details] [diff] [review]
Change "Help Contents" to "Firefox Help" v1

>diff -r 1ad1932defe6 browser/base/content/baseMenuOverlay.xul

>         <menuitem id="menu_openHelp"
>                   oncommand="openHelpLink('firefox-help')"
>+                  label="&helpContents.label;"
> #ifdef XP_MACOSX
>-                  label="&helpContentsMac.label;"
>                   key="key_openHelpMac"/>
> #else
>-                  label="&helpContents.label;"
>                   accesskey="&helpContents.accesskey;"
>                   key="key_openHelp"/>

Move the accesskey out of the ifdef as well? Doesn't hurt to have it defined on mac (even if it has no effect).

>diff -r 1ad1932defe6 browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd

>-<!ENTITY helpContents.label       "Help Contents">
>+<!ENTITY helpContents.label       "&brandShortName; Help">
> <!ENTITY helpContents.accesskey   "H">

You should rev the entity names here to highlight the change to localizers. productHelp.label/accesskey?

r=me with those addressed.
Comment on attachment 400304 [details] [diff] [review]
Change "Help Contents" to "Firefox Help" v1

a192=beltzner
Attachment #400304 - Flags: approval1.9.2+
(In reply to comment #6)
> (From update of attachment 400304 [details] [diff] [review])
> >diff -r 1ad1932defe6 browser/base/content/baseMenuOverlay.xul
> 
> >         <menuitem id="menu_openHelp"
> >                   oncommand="openHelpLink('firefox-help')"
> >+                  label="&helpContents.label;"
> > #ifdef XP_MACOSX
> >-                  label="&helpContentsMac.label;"
> >                   key="key_openHelpMac"/>
> > #else
> >-                  label="&helpContents.label;"
> >                   accesskey="&helpContents.accesskey;"
> >                   key="key_openHelp"/>
> 
> Move the accesskey out of the ifdef as well? Doesn't hurt to have it defined on
> mac (even if it has no effect).


Done.


> >diff -r 1ad1932defe6 browser/locales/en-US/chrome/browser/baseMenuOverlay.dtd
> 
> >-<!ENTITY helpContents.label       "Help Contents">
> >+<!ENTITY helpContents.label       "&brandShortName; Help">
> > <!ENTITY helpContents.accesskey   "H">
> 
> You should rev the entity names here to highlight the change to localizers.
> productHelp.label/accesskey?


Done.


> r=me with those addressed.
Attachment #400304 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed http://hg.mozilla.org/mozilla-central/rev/3bc5b7b5b671

and

Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/92374467156c
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
v with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090915 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20090915053258
Status: RESOLVED → VERIFIED
Verified fixed on 1.9.2 using  Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b2) Gecko/20091108 Firefox/3.6b2. Checked Win Vista and Win XP as well.
Whiteboard: verified1.9.2
Forgot to mark this bug as user-doc-complete. The change was actually made in November.
<https://support.mozilla.com/en-US/kb/Menu+Reference#Firefox_Help>
You need to log in before you can comment on or make changes to this bug.