516087 - [autoconfig] Pressing enter can lead to creating accounts at the wrong time.

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Mark Banner (:standard8)]

STR:

1) Enter name, email, password, press enter to go onto the next step.
2) Adjust settings because your configuration wasn't found
3) Press enter.

Expected results: nothing or re-test configuration.

Actual results: dialog moved onto the create account step (for me this was highlighted by the insecure server dialog) without re-testing configuration.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to make the enter key work better.

We decided to show the Create Account button, and have it disabled, instead of hiding it, but I forgot to update the onKeyDown handler.

So while I was there, I changed the 's to "s to make philor happy, and made the enter key re-test the configuration, cause that seemed nicer.  ;)

Thanks,
Blake.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 400201 [details] [diff] [review]
A patch to make the enter key work better.

So actually I've changed my mind on not worrying about this for b4 and I think given the patch is simple we'll land it.

It'll prevent people accidentally creating accounts at the wrong time.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/5c7fc4df7c25