Closed
Bug 516102
Opened 15 years ago
Closed 15 years ago
Refactor XPCNativeWrapperCtor into C++ callable and JS callable versions
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file, 1 obsolete file)
16.64 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Right now, XPCNativeWrapperCtor can be called by both JS and C++, which is confusing (and looking at cx->fp if we weren't called from JS is simply wrong).
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #400212 -
Attachment is obsolete: true
Attachment #400689 -
Flags: review?(jst)
Attachment #400212 -
Flags: review?(jst)
Comment 3•15 years ago
|
||
Comment on attachment 400689 [details] [diff] [review]
With a test
+ try {
+ is(new XPCNativeWrapper(window, Window).closed, false,
+ "able to wrap a window in a window XPCNativeWrapper");
+ new XPCNativeWrapper(document, Window);
The first of those two tests should be outside of the try shouldn't it?
r+sr=jst with that.
Attachment #400689 -
Flags: superreview+
Attachment #400689 -
Flags: review?(jst)
Attachment #400689 -
Flags: review+
Assignee | ||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•