Refactor XPCNativeWrapperCtor into C++ callable and JS callable versions

RESOLVED FIXED in mozilla1.9.3a1

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

Trunk
mozilla1.9.3a1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Right now, XPCNativeWrapperCtor can be called by both JS and C++, which is confusing (and looking at cx->fp if we weren't called from JS is simply wrong).
Created attachment 400212 [details] [diff] [review]
Fix
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #400212 - Flags: review?(jst)
Created attachment 400689 [details] [diff] [review]
With a test
Attachment #400212 - Attachment is obsolete: true
Attachment #400689 - Flags: review?(jst)
Attachment #400212 - Flags: review?(jst)
Comment on attachment 400689 [details] [diff] [review]
With a test

+    try {
+        is(new XPCNativeWrapper(window, Window).closed, false,
+           "able to wrap a window in a window XPCNativeWrapper");
+        new XPCNativeWrapper(document, Window);

The first of those two tests should be outside of the try shouldn't it?

r+sr=jst with that.
Attachment #400689 - Flags: superreview+
Attachment #400689 - Flags: review?(jst)
Attachment #400689 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/7e8e1dd4e8e6
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1

Updated

9 years ago
Depends on: 517163
You need to log in before you can comment on or make changes to this bug.