517163 - [Flashblock] Unexpected error = NS_ERROR_UNEXPECTED @ return Components.lookupMethod(untrustedObject, methodName).apply(untrustedObject, arguments);

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Philip Chee]

[please move to a more appropriate bugzilla component]

Flashblock stops working in the latest Minefield nightlies.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090916 Minefield/3.7a1pre

Flashblock 1.5.11.2

Error: Unexpected error = NS_ERROR_UNEXPECTED
Source file: chrome://flashblock/content/flashblock.xml
Line: 21


Line 21 is: return fun.apply(untrustedObject, arguments);

Code:

//From Jesse's XPCNativeWrapper: http://mavra.perilith.com/~luser/content/native.js
function nativeMethod(untrustedObject, methodName)
{
  // happier stack traces and faster multiple calls
  var fun = Components.lookupMethod(untrustedObject, methodName);
  
  return function()
  {
    return fun.apply(untrustedObject, arguments);
  }
}

Comment 1

[Philip Chee]

Note: turning JIT (chrome/content) on/off doesn't affect this problem.

Works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090914 Minefield/3.7a1pre
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090915 Minefield/3.7a1pre
Fails:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090916 Minefield/3.7a1pre

Could Bug 516102 have casued this, Blake?

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Yes.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

I haven't updated my brain to work in the new slimwrapper world yet. I'd forgotten that we have to morph when we *really* want an XPCWrappedNative. Like, say, when we're wrapping in an XPCNativeWrapper.

Comment 5

[(not currently active) Ted Mielczarek]

A Mochitest or something would be awesome :)

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/7263e09bf271

Landed with mochitest, even.