Closed Bug 516327 Opened 15 years ago Closed 15 years ago

Closing compose window with customize panel open should clean it up for recycling

Categories

(Thunderbird :: Message Compose Window, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Requisitioned from bug 509209 comment 19 et seq. - if you open a compose window, customize, then X out of the window without closing the sheet and reopen compose (in a way, and with prefs, that will use the recycled window) the customization panel is still there, which is a bit of a surprise.

The gSearchInput/GetSearchInput stuff is drive-by, because we were warning about gSearchInput (the gSearchInput from the 3pane, not the different gSearchInput from addrbook) being undefined when we nulled it out while closing the compose customization panel, but in fact where we called GetSearchInput to reinit it (in the 3pane case, where GetSearchInput was actually a function) after customization was the only place it was being initted, and the only places it's used are in suite/.
Attachment #400429 - Flags: review?(bugzilla)
Attachment #400429 - Flags: review?(bugzilla)
Attachment #400429 - Flags: review+
Attachment #400429 - Flags: approval-thunderbird3+
http://hg.mozilla.org/comm-central/rev/d74cb0f9b179
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: