51661 - js errors in navigator.js when clicking Leak Detector menuitems [leakDetector.* is not a function]

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stephen Walker]

using 2000090608 on win2k i get the following errors when clicking on the 
menuitems under the QA -> Leak Detector menu:

Dump Memory Leaks -> Error: leakDetector.vtable has no properties
                     Source File: chrome://navigator/content/navigator.js
                     Line: 1546

Trace Chrome ->      Error: leakDetector.vtable has no properties
                     Source File: chrome://navigator/content/navigator.js
                     Line: 1552

Trace Document ->    Error: leakDetector.vtable has no properties
                     Source File: chrome://navigator/content/navigator.js
                     Line: 1559

Comment 1

[Patrick C. Beard]

I wrote this stuff, and it currently isn't implemented on Windows. Sorry for the 
confusion.

Comment 2

[Thomas]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.1) Gecko/20040707
I just discovered that my Mozilla 1.7 final doesn't have the QA menuitem. 
Is this perhaps only available in nigtly builds?

Comment 3

[timeless]

[e-mail]: generally speaking (there's no guarantee that someone 
releases without the menus, but they try to).

fwiw this is trivial to fix, if you're interested in helping, someone on 
irc.mozilla.org #developers would gladly help you work on it. note that the 
actual items that will fail today are slightly different from when this bug was 
filed, but the fix is still the same:

namely adding:
if (!("functionToCall" in leakDetector)) return;
before:
leakDetector.functionToCall();

Comment 4

[Thomas]

To check the leak detector I installed a 1.8 alpha build.
It is now under Debug (not QA).
Clicking any of the 4 options (Dump Memory Leaks, Trace Chrome, Trace Document,
verbose) didn't do anything...
No action, no window, but no crash either...

Comment 5

[Erik Fabert]

Attachment: Check functions exist before calling them

I didn't add another check for traceObject() in traceDocument() because AFAIK
we always get all or nothing, depending on whether GC_LEAK_DETECTOR is defined.

Comment 6

[[e-mail]]

This is not exactly the nicest code... personally I'd like leakDetector to be
the actual XPCOM object, if it exists, as this could then be easily compared
for, although a second global would be necessary to track the verbosity.

Comment 7

[Erik Fabert]

Attachment: make leakDetector the XPCOM object

I found the patch ugly myself but the problem is I can't build with
LeakDetector enabled and thus can't check whether this works. Instead of flying
blind I decided to follow the suggestion in comment #3.

Comment 8

[[e-mail]]

This is looking good. But it occurs to me that we could alternatively disable
the entire leak detector menu if it is not found. Anyway, I'll just see if I can
build with the leak detector, to make sure the patch works when it's there :-)

Comment 9

[Erik Fabert]

I have a patch where I simply remove the menu and the separator above it if the 
leak detector is not there. But it adds a few lines and in the meantime I've 
found bug 236029 where timeless suggests not to bloat the code over this issue? 

Comment 10

[timeless]

so i'm inconsistent. sorry :)

remember, neil is module owner, i just express opinions at times based on my mood.

i think a single broadcaster or equivalent that causes the items to be hidden
when it's unavailable is probably best. -- note that this doesn't really relate
to the other issue you're trying to address.

Comment 11

[[e-mail]]

Comment on attachment 155432 [details] [diff] [review]
make leakDetector the XPCOM object

Hmm... so if I understand correctly, that leak detector only runs on the Mac
anyway, so someone with a mac should test this.

Comment 12

[Erik Fabert]

Attachment: Revised patch.

That last patch was broken, Boolean("false") returns true...

Comment 13

[timeless]

*** Bug 265444 has been marked as a duplicate of this bug. ***

Comment 14

[Thomas]

Referring to Comment #11.
If the leakdetector only runs on Mac?
Why is the OS then marked as Windows 2000?

Comment 15

[jhp (no longer active)]

Just tested this patch on Mac.  The menu items remain, but the they don't do
anything, nor do they cause Javascript errors any more.

Comment 16

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20050111] (release) (W98SE)

Bug still there.

Comment 17

[OstGote!]

*** Bug 236029 has been marked as a duplicate of this bug. ***

Comment 18

[OstGote!]

*** Bug 322328 has been marked as a duplicate of this bug. ***

Comment 19

[Martin Mokrejs]

I get with cvs HEAD (seamonkey/suite) build the following on linux-i686:

JavaScript error: chrome://debugqa/content/debugQAMenuOverlay.js, line 66: leakDetector.dumpLeaks is not a function
[Thread 0xb09ebb90 (LWP 1106) exited]

Comment 20

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".

Comment 21

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081014 SeaMonkey/2.0a2pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081012 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)
with |ac_add_options --enable-logrefcnt|

Error update
{
Error: leakDetector.dumpLeaks is not a function
Source File: chrome://debugqa/content/debugQAMenuOverlay.js
Line: 66

Error: leakDetector.traceObject is not a function
Source File: chrome://debugqa/content/debugQAMenuOverlay.js
Line: 72

Error: leakDetector.markObject is not a function
Source File: chrome://debugqa/content/debugQAMenuOverlay.js
Line: 79
}

Comment 22

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Hide the menu [Checkin: Comment 23]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081014 SeaMonkey/2.0a2pre] (nightly) (W2Ksp4)

Per comment 8.

Comment 23

[Serge Gautherie (:sgautherie)]

Comment on attachment 343154 [details] [diff] [review]
(Cv1) Hide the menu
[Checkin: Comment 23]

http://hg.mozilla.org/comm-central/rev/1f6bcd26cf45