516769 - WINCE IsLowMemory fixups

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

Two changes:

90% memory load is pretty high a value to test for low memory.  I decrease it to 80% and we seem to run much better (eg. we are tossing caches ahead of the point where things are much more critical).

During the point we notify callers of low-memory, we should be calling any system APIs that allow applications to request more memory and/or free up system resources.  Window Mobile has a function called SHCloseApps() that can be used.  I added a section after the notification where built-in system level flushers can be added.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/9a19776b0676

Comment 3

[Dietrich Ayala (:dietrich)]

could this have caused a Ts regression? it's in the range for bug 517915.

Comment 4

[Doug Turner (:dougt)]

Dietrich, this was strictly only windows mobile or windows ce.

Comment 5

[Benjamin Smedberg]

This patch broke WinCE --disable-libxul builds:
e:/builds/slave/winmo-hg/build/objdir/xulrunner/dist/sdk/bin/arm-wince-link.exe -NOLOGO -DLL -OUT:xpcom_core.dll -SUBSYSTEM:WINDOWSCE  pldhash.obj nsArrayEnumerator.obj nsArrayUtils.obj nsCategoryCache.obj nsCOMPtr.obj nsCOMArray.obj nsCRTGlue.obj nsComponentManagerUtils.obj nsEnumeratorUtils.obj nsID.obj nsIInterfaceRequestorUtils.obj nsINIParser.obj nsISupportsImpl.obj nsMemory.obj nsWeakReference.obj nsGREGlue.obj nsVersionComparator.obj nsTHashtable.obj nsQuickSort.obj nsVoidArray.obj nsTArray.obj nsThreadUtils.obj nsTObserverArray.obj nsCycleCollectionParticipant.obj nsDeque.obj BlockingResourceBase.obj DeadlockDetector.obj nsAutoLock.obj nsGenericFactory.obj nsProxyRelease.obj nsTextFormatter.obj nsXPComInit.obj nsXPCOMStrings.obj    ./module.res -MANIFESTUAC:NO     ../ds/xpcomds_s.lib ../io/xpcomio_s.lib ../components/xpcomcomponents_s.lib ../threads/xpcomthreads_s.lib ../proxy/src/xpcomproxy_s.lib ../base/xpcombase_s.lib ../reflect/xptcall/src/xptcall.lib ../reflect/xptcall/src/xptcmd.lib ../reflect/xptinfo/src/xptinfo.lib ../../dist/lib/xpt.lib ../string/src/string_s.lib    e:/builds/slave/winmo-hg/build/objdir/xulrunner/dist/lib/nspr4.lib e:/builds/slave/winmo-hg/build/objdir/xulrunner/dist/lib/plc4.lib e:/builds/slave/winmo-hg/build/objdir/xulrunner/dist/lib/plds4.lib  ole32.lib     
   Creating library xpcom_core.lib and object xpcom_core.exp
xpcombase_s.lib(nsMemoryImpl.obj) : error LNK2019: unresolved external symbol SHCloseApps referenced in function "public: unsigned int __cdecl nsMemoryImpl::RunFlushers(unsigned short const *)" (?RunFlushers@nsMemoryImpl@@QAAIPBG@Z)
xpcom_core.dll : fatal error LNK1120: 1 unresolved externals

Comment 6

[Doug Turner (:dougt)]

need to link against aygshell.lib when building xpcom_core?

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9e6cd2038958