51688 - Use Stylesheet menu: differentiate "None" from disabling all styles

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Tobias Burnus]

Hi this is with 2000-09-06-21/Linux and a strip off from a bug reported in 6782.

The menu item View|Use stylesheet|None should be changed in order to reflect
that "None" doesn't disable the stylesheets totally, but only those that are in
a external file.
Suggested menu entry "Minimal Page Style"

Comment 1

[Tobias Burnus]

The entry might be changed back to "None" if bug 51690 is solved or both entries
should be available.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

There have been many other proposals for how to differentiate between turning
off all preferred and alternate stylesheets and turning off all author styles. 
See the long discussion on bug 6782.

Comment 3

[Pierre Saslawsky]

*** This bug has been marked as a duplicate of 6782 ***

Comment 4

[Christine Hoffman]

Verified dup of #6782

Comment 5

[fantasai]

Splitting up bug 6782 ("UI for alternate and user stylesheets").

"One bug report == one issue is one of the golden rules of Bugzilla because it
enables independent tracking and prioritization of each issue."
                                              -- [e-mail], bug 4510

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I don't think the change in the title of this bug is the right solution, so I'm
retitling it.  The problem is that we need to differentiate "None" from
disabling all author styles (which should probably disable stylistic attributes
in HTML just as much as persistent CSS stylesheets).

Comment 7

[Pierre Saslawsky]

*** This bug has been marked as a duplicate of 32372 ***

Comment 8

[fantasai]

This needs to be tracked separately. If bug 51690 doesn't get fixed for Moz1.0, 
then this really should. If 51690 does get fixed, we can WONTFIX this.

And anyway, it's not a duplicate: this isn't about providing a 'disable 
stylesheets' option, it's about marking the 'disable alternate & preferred 
stylesheets' option as such, instead of as "none". I'll admit it's in the wrong 
component, though--moving to UI Design.

If you want this off your list, Pierre, assign it to me. I think I can handle a 
string change, if it comes to that. :)

Comment 9

[Pierre Saslawsky]

I did not want to have a bug just for renaming a string, I thought it could be 
part of bug 32372.  But you're right: let's keep the bug open because we still 
haven't decided on a UI.  We have at least two possibilities:
1) Have separate settings: a pref to disable all styles and a menu item in the 
Stylesheet menu to disable just the linked stylesheets.
2) Merge the two settings: make the menu item reflect the pref's state and 
disable all styles.

Comment 10

[fantasai]

> 1) Have separate settings: a pref to disable all styles and a menu item in the 
> Stylesheet menu to disable just the linked stylesheets.

I should be able to disable all author-level styles on a page-by-page basis--and 
that implies not in the prefs.

> 2) Merge the two settings: make the menu item reflect the pref's state and 
> disable all styles.

So, if I disable all author-level styles in the prefs, and then enable them in 
the menus, what happens?

I don't think we need a pref for this--the menu item should do. I doubt many 
people will want to browse with the entire author cascade level disabled all the 
time. :)

Comment 11

[basic]

the menu should override the pref I guess

Comment 12

[Kevin McCluskey (gone)]

Moving to mozilla1.1. Engineers are overloaded!

Comment 13

[Christine Hoffman]

reassigning qa contact to component contact.

Comment 14

[Kevin McCluskey (gone)]

Bulk moving from Moz1.1 to future-P1. I will pull from this list when scheduling
work post Mozilla1.0.

Comment 15

[fantasai]

> Moving to mozilla1.1. Engineers are overloaded!

I'm not, though, so I'm taking this, if Pierre doesn't mind. :)

Comment 16

[fantasai]

Attachment: patch

Comment 17

[fantasai]

Another option is to change the wording to "Basic Page Style".

Comment 18

[fantasai]

Attachment: patch v2 ("Basic Page Style")

Comment 19

[fantasai]

Attachment: patch v3

Added accesskey, as requested by mpt

Comment 20

[Matthew T (active 1999-2002)]

Comment on attachment 75947 [details] [diff] [review]
patch v3

r=mpt, on the understanding that this is a temporary measure until `No Author
Styles' is implemented

Comment 21

[Alec Flett]

Comment on attachment 75947 [details] [diff] [review]
patch v3

sr=alecf

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 75947 [details] [diff] [review]
patch v3

not sure when mpt became a reviewer. assuming that alecf's sr counts as an r=
and this has brendan's rubberstamp for wording only changes. a=asa (on behalf
of drivers) for checkin to the 1.0 trunk

Comment 23

[John P Baker]

The menu access key (B) shows on altenate stylesheet as well as
preferred style sheet.

http://www.bristol.ac.uk/is/selfhelp/documentation/docs-g1/docs-g1.htm

Comment 24

[Asa Dotzler [:asa]]

has this landed yet? time is running out.

Comment 25

[fantasai]

checkin by timeless Mar 26 19:17

Comment 26

[John P Baker]

I don't think the problem it caused with access keys has been fixed though.

Go to http://www.w3.org/Style/CSS/
View/Use Style and (in Win2K at least) you get underlined Bs
all over the place.

(Admittedly this is on a 20020328 build because of Easter break)

Comment 27

[John P Baker]

Sorry - found it as bug 133842