Closed Bug 517134 Opened 15 years ago Closed 15 years ago

Per-server newsgroup filters do not work

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: jcranmer, Assigned: bwinton)

References

Details

(Keywords: regression, Whiteboard: [no l10n impact])

Attachments

(1 obsolete file)

When I was playing around with filter settings, I was unable to select the individual newsgroup filters in my dialog, instead just getting a "Choose this news server" link as opposed to entries like sci.math Error console says: Error: GetMsgFolderFromUri is not defined Source File: chrome://messenger/content/folderWidgets.xml Line: 315
This is a very recent regression, as my custom builds from just 2 weeks ago (2009-09-01) do not show this, but recent nightlies do.
Whiteboard: regression
I have confirmed that this bug is a regression from attachment 400569 [details] [diff] [review] from bug 516535. I think it should block beta4. A better title though would be "per-folder newsgroups filters do not work."
Blocks: 516353
Flags: blocking-thunderbird3?
Target Milestone: --- → Thunderbird 3.0b4
Keywords: regression, relnote
Whiteboard: regression
STR: 1) Select tools/message filters ("Message Filters" dialog appears) 2) Select "Filters for" dropdown menu. 3) scroll down to a newsgroup server Expected results: list of folders for the newsgroup appears Actual results: only "choose this news server" appears, along with the error console message from comment 0.
Attached patch add widgetglue.js (obsolete) — Splinter Review
Here's the patch that fixes this, in case there is a chance to get this fixed for beta4. It's really simple - but XUL is not my area of expertise, so I would appreciate careful review.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Attachment #401213 - Flags: review?(bugzilla)
Whiteboard: [no l10n impact]
Not going to cause a b4 respin on this - this doesn't break pre-existing filters and there's unlikely to be lots of users editing newsgroup filters. We'll take it for rc1 and if something should cause a b4 respin, we'll consider it then.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.0rc1
I believe I fixed this in http://hg.mozilla.org/comm-central/rev/2aea95c35322 . (Which is to say, I tested it on trunk, and it works for me.) Thanks, Blake.
Assignee: kent → bwinton
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #401213 - Attachment is obsolete: true
Attachment #401213 - Flags: review?(bugzilla)
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: