517134 - Per-server newsgroup filters do not work

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Joshua Cranmer [:jcranmer]]

When I was playing around with filter settings, I was unable to select the individual newsgroup filters in my dialog, instead just getting a "Choose this news server" link as opposed to entries like sci.math

Error console says:
Error: GetMsgFolderFromUri is not defined
Source File: chrome://messenger/content/folderWidgets.xml
Line: 315

Comment 1

[Kent James (:rkent)]

This is a very recent regression, as my custom builds from just 2 weeks ago (2009-09-01) do not show this, but recent nightlies do.

Comment 2

[Kent James (:rkent)]

I have confirmed that this bug is a regression from attachment 400569 [details] [diff] [review] from bug 516535. I think it should block beta4. A better title though would be "per-folder newsgroups filters do not work."

Comment 3

[Kent James (:rkent)]

STR:

1) Select tools/message filters ("Message Filters" dialog appears)
2) Select "Filters for" dropdown menu.
3) scroll down to a newsgroup server

Expected results: list of folders for the newsgroup appears
Actual results: only "choose this news server" appears, along with the error
console message from comment 0.

Comment 4

[Kent James (:rkent)]

Attachment: add widgetglue.js

Here's the patch that fixes this, in case there is a chance to get this fixed for beta4. It's really simple - but XUL is not my area of expertise, so I would appreciate careful review.

Comment 5

[Mark Banner (:standard8)]

Not going to cause a b4 respin on this - this doesn't break pre-existing filters and there's unlikely to be lots of users editing newsgroup filters.

We'll take it for rc1 and if something should cause a b4 respin, we'll consider it then.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

I believe I fixed this in http://hg.mozilla.org/comm-central/rev/2aea95c35322 .
(Which is to say, I tested it on trunk, and it works for me.)

Thanks,
Blake.