517168 - When there is no profile/emails yet gloda send warnings in the console (Gloda.myContact is null)

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ludovic Hirlimann [:Usul]]

On first startup with an empty profile I get this in the Error console :

2009-09-17 10:35:20	gloda.ds.qfq	ERROR	Exception: TypeError: Gloda.myContact is null

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

I get this too. At some point I also got a hard error, I don't have the line number handy though.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

In light of work on bug 485268 it would be nice if Thunderbird could also work without issues if there is no mail account. If Lightning has a way to extend the TB new account dialog (or at least a way to not show it), then we would be a step closer to being able to provide calendar-only UI if there is a calendar but no mail account.

Comment 3

[Florian Quèze [:florian]]

The location of the error is:

Error: Gloda.myContact is null
Source File: file:///.../DailyDebug.app/Contents/MacOS/components/glautocomp.js
Line: 286

The blamed line is:
      if (!(Gloda.myContact.id in this.contactCollection._idMap))

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch

I've only added a null check without trying to understand the surrounding code so this may be wrong, but at least it silences the error (I dislike noise in my error console ;)).

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 609299 [details] [diff] [review]
Patch

A quiet console is a happy console!  Thanks!

Comment 6

[Florian Quèze [:florian]]

Thanks for the quick review!

http://hg.mozilla.org/comm-central/rev/5db117e65316