Last Comment Bug 517168 - When there is no profile/emails yet gloda send warnings in the console (Gloda.myContact is null)
: When there is no profile/emails yet gloda send warnings in the console (Gloda...
Status: RESOLVED FIXED
: calendar-integration
Product: Thunderbird
Classification: Client Software
Component: Search (show other bugs)
: 3.0
: All All
: -- trivial (vote)
: Thunderbird 14.0
Assigned To: Florian Quèze [:florian] [:flo] (PTO until August 29th)
:
Mentors:
Depends on:
Blocks: 515237
  Show dependency treegraph
 
Reported: 2009-09-17 01:40 PDT by Ludovic Hirlimann [:Usul]
Modified: 2012-03-28 02:36 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (1.04 KB, patch)
2012-03-26 06:28 PDT, Florian Quèze [:florian] [:flo] (PTO until August 29th)
bugmail: review+
Details | Diff | Splinter Review

Description Ludovic Hirlimann [:Usul] 2009-09-17 01:40:33 PDT
On first startup with an empty profile I get this in the Error console :

2009-09-17 10:35:20	gloda.ds.qfq	ERROR	Exception: TypeError: Gloda.myContact is null
Comment 1 Philipp Kewisch [:Fallen] 2009-11-25 11:36:26 PST
I get this too. At some point I also got a hard error, I don't have the line number handy though.
Comment 2 Philipp Kewisch [:Fallen] 2011-03-08 08:43:31 PST
In light of work on bug 485268 it would be nice if Thunderbird could also work without issues if there is no mail account. If Lightning has a way to extend the TB new account dialog (or at least a way to not show it), then we would be a step closer to being able to provide calendar-only UI if there is a calendar but no mail account.
Comment 3 Florian Quèze [:florian] [:flo] (PTO until August 29th) 2012-03-26 06:20:39 PDT
The location of the error is:

Error: Gloda.myContact is null
Source File: file:///.../DailyDebug.app/Contents/MacOS/components/glautocomp.js
Line: 286

The blamed line is:
      if (!(Gloda.myContact.id in this.contactCollection._idMap))
Comment 4 Florian Quèze [:florian] [:flo] (PTO until August 29th) 2012-03-26 06:28:25 PDT
Created attachment 609299 [details] [diff] [review]
Patch

I've only added a null check without trying to understand the surrounding code so this may be wrong, but at least it silences the error (I dislike noise in my error console ;)).
Comment 5 Andrew Sutherland [:asuth] 2012-03-26 10:50:00 PDT
Comment on attachment 609299 [details] [diff] [review]
Patch

A quiet console is a happy console!  Thanks!
Comment 6 Florian Quèze [:florian] [:flo] (PTO until August 29th) 2012-03-28 02:36:45 PDT
Thanks for the quick review!

http://hg.mozilla.org/comm-central/rev/5db117e65316

Note You need to log in before you can comment on or make changes to this bug.