517269 - getCookie is not defined in line 233 when searching in the new Ask a Question form

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P5)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

When I load http://support-stage.mozilla.org/tiki-view_forum.php?locale=en-US&forumId=1, type a search term, and click Search, I get:

getCookie is not defined in line 233

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

This actually isn't specific to the forums, so re-slotting components.

Comment 2

[James Socol [:jsocol, :james]]

Probably caused by tiki-js.js not being loaded everywhere it's needed. I know I've seen this error on other pages, as well, so I'll keep an eye out.

Comment 3

[Paul Craciunoiu [:paulc]]

I propose we just remove that annoying getCookie() call. I believe it's only used to fill out the search form with the previous search value -- why is that useful?

Comment 4

[[:Cww]]

Not useful here, getting rid of getCookie sounds good.

Comment 5

[Paul Craciunoiu [:paulc]]

David, maybe we should discuss the usefulness of pre-filling the search box with the last used value. Could you perhaps reiterate why it was set initially, and if we want it on the small search in the sidebar as well?

Comment 6

[David Tenser [:djst]]

This was discussed before but I can't find the bug number so let me reiterate my personal opinion here:

I don't see the point of remembering the value of the search box for any pages BUT the search results page. In other words, I would be more than fine with removing it from pages like this.

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: v1

I also searched the DB and luckily found nothing. Hence, this should take care of all the search-related cookies we set. I grepped for: "fsearch", "getCookie", "setCookie" and looked at all instances, so I'm pretty sure I didn't miss any.

Comment 8

[James Socol [:jsocol, :james]]

Comment on attachment 404873 [details] [diff] [review]
v1

WFM, but I'm keeping my eyes open during QA.

Comment 9

[Paul Craciunoiu [:paulc]]

r52968 (trunk)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

I filed bug 520941 while testing this fix; that's not a regression from this patch, at least (already in production).

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Sizable change, but we've got a pretty competent BFT to run this release, along with ad-hoc testing (of which I've already done a fair amount).

This specific fix is good, and we'll aim to shake out regressions as we work on 1.4.1.

Verified FIXED.

Comment 12

[Paul Craciunoiu [:paulc]]

r53558

Comment 13

[Paul Craciunoiu [:paulc]]

Previous was for prod. I managed to commit to fennec without conflicts too: r53559

Comment 14

[Louis-Philippe Huberdeau]

Looks like sumo_only or tiki_fixed, can't find occurences in tiki templates.

Comment 15

[Paul Craciunoiu [:paulc]]

Definitely sumo_only.