Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090917 Namoroka/3.6a2pre (.NET CLR 3.5.30729) STR: 1. Delete/move folder %APPDATA%\Mozilla\Firefox\Crash Reports\submitted 2. Crash Firefox without network connection to get a pending crash report. 3. Restore network connection, open Firefox and go to about:crashes 4. Click pending crash report id Expected: Report is submitted Actual: Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileOutputStream.init]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://global/content/crashes.js :: writeSubmittedReport :: line 117" data: no Manually creating folder named "submitted" in "Crash Reports" allows resubmission to succeed.
Good catch, thanks!
Created attachment 432866 [details] [diff] [review] Create the Crash Reporter/submitted/ directory if it doesn't already exist
8 years ago
Comment on attachment 432866 [details] [diff] [review] Create the Crash Reporter/submitted/ directory if it doesn't already exist Should have fixed this a while ago, thanks! This could also really use a test. We could probably test it easily by just changing the existing test that submits from about:crashes to not put anything in the submitted dir (or create the dir). Removing the add_fake_crashes call here: http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/browser_aboutCrashesResubmit.js#127 and the create_subdir call here: http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/browser/aboutcrashes_utils.js#29 Would probably be sufficient.
http://hg.mozilla.org/mozilla-central/rev/56e32c24f59c Leaving open for testcase.
Nah, we have a flag for that. Just close it.
Verified with STR from comment 0. Thank you. Should this go into Lorentz along with bug 544936?
8 years ago
Thanks, yes it should. Reopening for backport.
Once a bug has been resolved on trunk, it is marked RESOLVED FIXED. Any branch-related backports should be tracked with flags or whiteboard notes.
http://hg.mozilla.org/projects/firefox-lorentz/rev/1ae57766034c This landed well before freeze, I just forgot to update the bug.
Blanket approval for Lorentz merge to mozilla-1.9.2 a=beltzner for 126.96.36.199 - please make sure to mark status1.9.2:.4-fixed
Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430