517510 - NetworkGeolocationProvider.js does not properly check for bad responses.

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Bob Aman]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 GTB6
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 GTB6

Every once in a rare while, this snippet of code breaks (line 232 on my copy of FF):

var newLocation = new WifiGeoPositionObject(response.location.latitude, response.location.longitude, response.location.accuracy);

The response doesn't have a location field, so you get a "response.location is undefined" error.

A simple check to verify that response.location isn't null should fix this.


Reproducible: Sometimes

Steps to Reproduce:
Impossible to reproduce on demand.

Comment 1

[Britt Selvitelle]

We are also seeing this while hacking on GeoLocation for Twitter.

Comment 5

[Robert Kaiser]

The dupes seem to confirm this, but it's a Geolocation bug.

Comment 6

[Dietrich Ayala (:dietrich)]

OS->All per the duped bugs.

Comment 7

[rgb]

With FF 3.5 I was able to catch the error and apply a workaround. With 3.6 the error seems to be uncatchable, and execution just stops.

On FF 3.6.3 (Linux), the error is "location is undefined" and appears at line 91 of file:///usr/lib/firefox-3.6.3/components/NetworkGeolocationProvider.js:

 this.coords = new WifiGeoCoordsObject(location.latitude,
                                       location.longitude,
                                       location.accuracy || 12450, // .5 * circumference of earth.
                                       location.altitude || 0,
                                       location.altitude_accuracy || 0);

Comment 8

[Hanno Schlichting]

This code today lives at https://dxr.mozilla.org/mozilla-central/source/dom/system/NetworkGeolocationProvider.js#515 which does a check for "!xhr.response || !xhr.response.location" before trying to access the ".location".