Closed Bug 517722 Opened 14 years ago Closed 14 years ago

Update SM Prefs Overlay with new IDs

Categories

(Other Applications :: ChatZilla, defect)

Product:
Other Applications
Component:
ChatZilla
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file)

Change overlay to use new ids in SM pref panes [Checkin: Comment 5]
1.03 KB, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review 
Once the fix to bug 516398 lands, Chatzilla's overlay for SM will need updating so it inserts itself into SM's pref tree in the correct place.
This patch:
* Changes insertafter to be insertbefore with an id that exists.
Assignee: rginda → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #401664 - Flags: review?
Attachment #401664 - Flags: review? → review?(rginda)
Comment on attachment 401664 [details] [diff] [review]
Change overlay to use new ids in SM pref panes [Checkin: Comment 5]

There are no releases of SeaMonkey that would rely on the old insertafter, correct?
Attachment #401664 - Flags: review?(rginda) → review?(silver)
(In reply to comment #2)
> (From update of attachment 401664 [details] [diff] [review])
> There are no releases of SeaMonkey that would rely on the old insertafter,
> correct?
No final releases, correct.
Comment on attachment 401664 [details] [diff] [review]
Change overlay to use new ids in SM pref panes [Checkin: Comment 5]

Good good.
Attachment #401664 - Flags: review?(silver) → review+
Comment on attachment 401664 [details] [diff] [review]
Change overlay to use new ids in SM pref panes [Checkin: Comment 5]

Checking in:
xul/content/prefsOverlay.xul;
new revision: 1.11; previous revision: 1.10
done
Attachment #401664 - Attachment description: Change overlay to use new ids in SM pref panes → Change overlay to use new ids in SM pref panes [Checkin: Comment 5]
All fixed, thanks :)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: fixed-seamonkey2.0
Resolution: --- → FIXED
(In reply to comment #2)
> (From update of attachment 401664 [details] [diff] [review])
> There are no releases of SeaMonkey that would rely on the old insertafter,
> correct?
All of the old builds would work with the new insertbefore anyway.
You need to log in before you can comment on or make changes to this bug.