No Lightning pref UI in SeaMonkey

RESOLVED FIXED in 1.0b1

Status

Calendar
Lightning: SeaMonkey Integration
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug, {fixed-seamonkey2.0, relnote})

Trunk
1.0b1
fixed-seamonkey2.0, relnote
Dependency tree / graph

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

8 years ago
When installing Lightning into SeaMonkey, there's no way to get to preferences UI as Lightning hooks into Thunderbird-specific UI for this.

Comment 1

8 years ago
I have a WIP patch for this.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED

Updated

8 years ago
Depends on: 516453
(Reporter)

Updated

8 years ago
Blocks: 516883

Updated

8 years ago
Assignee: philip.chee → nobody
(Assignee)

Comment 2

8 years ago
Created attachment 400995 [details]
WIP
Assignee: nobody → neil
(Reporter)

Updated

8 years ago
No longer blocks: 516883
Duplicate of this bug: 516883
(Assignee)

Comment 4

8 years ago
Created attachment 401035 [details] [diff] [review]
diff -w
Attachment #400995 - Attachment is obsolete: true
Attachment #401035 - Flags: review?(mschroeder)
Comment on attachment 401035 [details] [diff] [review]
diff -w

>diff -Npruw comm.d45144dc165c/calendar/base/content/preferences/timezones.xul comm/calendar/base/content/preferences/timezones.xul
>--- comm.d45144dc165c/calendar/base/content/preferences/timezones.xul	2009-09-16 15:27:02.000000000 +0100
>+++ comm/calendar/base/content/preferences/timezones.xul	2009-09-16 15:27:02.000000000 +0100
>@@ -58,14 +58,14 @@
>                         type="string"/>
>         </preferences>
> 
>+        <groupbox>
>         <caption label="&pref.calendar.timezones.list.caption;"/>
> 
>         <menulist id="calendar-timezone-menulist"
>                   preference="calendar-timezone-local">
>             <menupopup id="calendar-timezone-menupopup"/>
>         </menulist>
>-
>-        <separator/>
>+        </groupbox>
> 
>     </vbox>
> </overlay>

I'm not sure this is needed but okay. Obviously, it is needed for SeaMonkey because you merge the content of general and timezone preference panes. ;-)


>diff -Npruw comm.d45144dc165c/calendar/lightning/content/communicator-overlay-preferences.xul comm/calendar/lightning/content/communicator-overlay-preferences.xul
>--- comm.d45144dc165c/calendar/lightning/content/communicator-overlay-preferences.xul	1970-01-01 01:00:00.000000000 +0100
>+++ comm/calendar/lightning/content/communicator-overlay-preferences.xul	2009-09-16 15:27:02.000000000 +0100
[...]
>+    <treechildren id="prefsPanelChildren">
>+        <treeitem container="true"
>+                            id="lightning"
>+                            label="&lightning.taskLabel;"
>+                            prefpane="paneLightning">

The indentation of the attributes seems to be off here and everywhere in this file. The original (messenger-overlay-preferences.xul) has them aligned correctly. Please, fix this before checkin.


r=mschroeder, but please get additional review for the SeaMonkey overlay from someone who knows SeaMonkey better than me.
Attachment #401035 - Flags: review?(mschroeder) → review+

Comment 6

8 years ago
With this patch the Lightning Prefs are the last entry, it probably needs:
insertafter="editor,mailnews,navigator"
adding to the the first treeitem in the overlay.

Comment 7

8 years ago
(In reply to comment #6)
> With this patch the Lightning Prefs are the last entry, it probably needs:
> insertafter="editor,mailnews,navigator"
> adding to the the first treeitem in the overlay.

Okay, that shifts it above Debug but still below Privacy & Security and Advanced, so needs something more than that.
The "Alarms" and "Views" pref panels go off the edge of the Preferences window.
(Assignee)

Comment 8

8 years ago
(In reply to comment #5)
>(From update of attachment 401035 [details] [diff] [review])
>>diff -Npruw
>The indentation of the attributes seems to be off here
That would be due to the -w diff ;-)

(In reply to comment #7)
>(In reply to comment #6)
>>With this patch the Lightning Prefs are the last entry, it probably needs:
>>insertafter="editor,mailnews,navigator"
>>adding to the the first treeitem in the overlay.
Where would you like it to be?

>The "Alarms" and "Views" pref panels go off the edge of the Preferences window.
With those fixes they didn't for me on Windows. I'm not sure what's best here.
(Reporter)

Comment 9

8 years ago
(In reply to comment #8)
> >The "Alarms" and "Views" pref panels go off the edge of the Preferences window.
> With those fixes they didn't for me on Windows. I'm not sure what's best here.

I think we should get it in as it is for now and look at those in a followup.

Updated

8 years ago
Blocks: 517700

Updated

8 years ago
Blocks: 517705

Comment 10

8 years ago
(In reply to comment #8)
> (In reply to comment #7)
> >(In reply to comment #6)
> >>With this patch the Lightning Prefs are the last entry, it probably needs:
> >>insertafter="editor,mailnews,navigator"
> >>adding to the the first treeitem in the overlay.
> Where would you like it to be?
I would say before Privacy & Security - sorted with deleting/editing localstore.rdf
> 
> >The "Alarms" and "Views" pref panels go off the edge of the Preferences window.
> With those fixes they didn't for me on Windows. I'm not sure what's best here.
They definitely are off the edge on Linux. Follow-up bug 517705

Updated

8 years ago
Attachment #401035 - Flags: review+

Comment 11

8 years ago
Comment on attachment 401035 [details] [diff] [review]
diff -w

r=me for SM with position of lightning preference category before privacy & security and advanced
(Assignee)

Comment 12

8 years ago
Created attachment 401650 [details] [diff] [review]
Fixed position of Lightning category
Attachment #401035 - Attachment is obsolete: true
Attachment #401650 - Flags: review?(iann_bugzilla)
(In reply to comment #12)
> Created an attachment (id=401650) [details]
> Fixed position of Lightning category

communicator-overlay-preferences.xul still seems to have wrong indentation, also without -w option (which doesn't influence new files afaik).
(Assignee)

Comment 14

8 years ago
Created attachment 401657 [details] [diff] [review]
Fixed indentation

Sorry for the misunderstanding.
Attachment #401650 - Attachment is obsolete: true
Attachment #401657 - Flags: review?(iann_bugzilla)
Attachment #401650 - Flags: review?(iann_bugzilla)

Comment 15

8 years ago
Comment on attachment 401657 [details] [diff] [review]
Fixed indentation

Chatzilla will need be fixed too, but that would have to be in another bug.
Attachment #401657 - Flags: review?(iann_bugzilla) → review+

Updated

8 years ago
Blocks: 517722

Comment 16

8 years ago
(In reply to comment #14)
> Created an attachment (id=401657) [details]
> Fixed indentation
> 
> Sorry for the misunderstanding.
a-SM2.0=me for SM part of patch. There is a blank line at the end of the prefs overlay you could get rid of too.
(Assignee)

Comment 17

8 years ago
(In reply to comment #15)
> (From update of attachment 401657 [details] [diff] [review])
> Chatzilla will need be fixed too, but that would have to be in another bug.
Chatzilla was using editor,mailnews,navigator which was wrong anyway :-(
(Assignee)

Comment 18

8 years ago
Pushed changeset 7d8e4a617bb4 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: fixed-seamonkey2.0
Resolution: --- → FIXED
Target Milestone: --- → 1.0

Updated

8 years ago
Keywords: relnote
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.