517723 - Shredder "Empty Trash" on top of Trash tree does nothing in Smart-Folder view

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P2)

Description

[Henry N.]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.2) Gecko/20090730 SUSE/3.5.2-2.1 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

The Trash have a list of folders (once per account). If I stay on top of Trash (and not on an account) and use the menu "File"* "Empty Trash" or the mouse context menu "empty trash", then TB asked me "doing this now?", and than it does nothing.


Reproducible: Always

Steps to Reproduce:
1. Have some messages in "Trash" * "Local Folder"
2. Select the "Trash" self, not the "Local Folder"
3. use menu "Empty Trash" or right mouse key and "Empty Trash"
4. If a question popped up "You are sure?" (or so), than say yes.
Actual Results:  
All messages in "Trash" * "Local Folder" still exist.

Expected Results:  
Empty the complete Trash for all accounts.

That no problem, that I needs to select first an account (for example "Local Folder") and than use the "Empty Trash" there.

Please disable the menu "Empty Trash", if no account is selected.

Comment 1

[Henry N.]

Problem exist only in the "Smart-Folder" view.

Comment 2

[Ludovic Hirlimann [:Usul]]

confirming on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4. Error console is empty.

Comment 3

[David :Bienvenu]

there are several bugs having to do with executing commands on smart folders (empty trash, compact inbox, etc), that we should try to fix for rc1. It shouldn't be too hard to fix them, so I'm going to mark this blocking.

Comment 4

[Mark Banner (:standard8)]

I believe this won't have l10n impact.

Comment 5

[Henry N.]

Smart Folders should not the default view for new profile.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

The nsLocalMailFolder.cpp change is really just extra protection - with this patch, we shouldn't try to call empty trash on the smart folders trash, but just in case some other UI tries to do that, it would be nice not to wipe out the smart trash.

Comment 7

[David :Bienvenu]

Attachment: proposed fix, v2

Standard8 pointed out that empty trash when you've got the smart inbox selected should empty all the trashes. So I made empty trash with any top-level smart folder selected empty all the trashes.

If you have a non-smart folder selected, e.g., the inbox of one of your accounts, I just empty the trash of the selected account.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 403596 [details] [diff] [review]
proposed fix, v2

(no sr required).

This seems reasonable now, though I feel we should just get clarkbw to give his ok.

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 403596 [details] [diff] [review]
proposed fix, v2

This looks good though I feel like in the future we might want an alternate confirmation dialog for this.  The current dialog does say that the trash and subfolders will be emptied so I think it's alright now.  However in the future I'd prefer something that let you know how many / which accounts trash folders you were emptying.

Comment 10

[David :Bienvenu]

fix checked in.