517773 - Give the option of what the find - highlight all color should be

Status: NEW

(Toolkit :: Find Toolbar, enhancement, P5)

Description

[Lady Aleena]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)

The color to highlight all of the instances of a found word or phrase used to be a yellow background with black text instead of purple background with white text. I want to have the option to change that color back to yellow with black, or some other combination that is to my liking.

Reproducible: Always




When I think of highlighting, I think of the box of markers that had four colors: yellow (standard color), blue, green, and pink. It would be nice to have a similar box of colors in Firefox.

Comment 1

[Marien Zwart]

The current purple was picked in bug 451204 comment 19 to fit a pretty long list of constraints. Just making this a (hidden) pref is not sufficient: obvious choices like yellow would trigger the background/foreground color swapping bug 451204 avoided. See bug 451204 comment 14 for a possible approach to making lighter colors work without swapping. I think bug 451204 comment 15 is backwards: the proposed change is not to make highlighting stand out *more* than the selection does, it's to make it acceptable for this highlighting to stand out *less* than the selection does.

Comment 2

[Deleted User]

The current search highlight color is not a helpful but a hindering feature for visually impaired people like me. I'm suffering from deuteranopia. Contrary to the new purple highlighter, the old yellow one was much more salient to me. There's no form of color vision deficiency I know of, except for monochromasia (total color blindness), which would stand in the way of a yellow highlighter.

A proper solition, which would not revive old bugs would be a user defined highlighter color.

Until this issue is solved, i'm trying to get around it using the user defined values mentioned in Bug 505089 (https://bugzilla.mozilla.org/show_bug.cgi?id=505089). Black background and yellow text is still much more acceptable to me than white on purple.

Comment 3

[[:Aleksej]]

Related: bug 426731.

Comment 4

[Luís Miguel [:quicksaver] (not reading bugmail)]

As already mentioned elsewhere, this option is available in about:config by changing preferences:

ui.textHighlightBackground
ui.textHighlightForeground

Add-on FindBar Tweak is available, through a color picker in its preferences dialog, these values can be changed so you can select your highlight color. Just thought this should be mentioned here as an alternative.