517788 - [Mac Classic] Download Manager polish

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

The progress meters used in trees has no native look at all. The black progress bar looks terrible on mac. We should at least try to mimic some of the colors in native progress bars (since -moz-appearance: progressbar won't work)

Comment 1

[Stefan [:stefanh]]

Attachment: polish downloadmanager

This patch also fixes the button and the search field (makes them smaller). For the search field, I use the "compact" class - only affects mac (see textbox.css in toolkit). I also made some tweaks of the progressDialog (why is it a window?). Screenshots coming up.

Comment 2

[Stefan [:stefanh]]

Attachment: Screenshots, download manager before - after

Here are some screenshots. From top to bottom: Before - aqua - graphite - diabled.

Comment 3

[Stefan [:stefanh]]

Attachment: Screenshots, progressDialog before - after

Comment 4

[Stefan [:stefanh]]

Comment on attachment 401741 [details]
Screenshots, download manager before - after

Note: the "Clear List" button might have changed its vertical position with 1px since I did thit screenshot

Comment 5

[Stefan [:stefanh]]

Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Seems I slipped when requesting this...

Comment 6

[Karsten Düsterloh]

Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Whew, the old progressmetres were truly scary!

>diff --git a/suite/common/downloads/progressDialog.xul b/suite/common/downloads/progressDialog.xul
>+<window id="dlProgressWindow"
>+        xmlns:html="http://www.w3.org/1999/xhtml"
>         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"

Please move the default namespace before the html one.


r=me with that.

Comment 7

[[e-mail]]

Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

>+/* There's no way this will look like a native progressbar, but we can at least
>+   try to mimic the aqua, graphite and non-active colors. */
>+treechildren::-moz-tree-progressmeter {
I take it you've filed a bug on toolkit for this?

Comment 8

[Stefan [:stefanh]]

(In reply to comment #7)
> (From update of attachment 401740 [details] [diff] [review])
> >+/* There's no way this will look like a native progressbar, but we can at least
> >+   try to mimic the aqua, graphite and non-active colors. */
> >+treechildren::-moz-tree-progressmeter {
> I take it you've filed a bug on toolkit for this?

There is bug 285508 (core: xul).

Comment 9

[Stefan [:stefanh]]

Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Low-risk, download manager mac theme enhancements.

Comment 10

[[e-mail]]

(In reply to comment #8)
>(In reply to comment #7)
>> (From update of attachment 401740 [details] [diff] [review])
>>>+/* There's no way this will look like a native progressbar, but we can at least
>>>+   try to mimic the aqua, graphite and non-active colors. */
>>>+treechildren::-moz-tree-progressmeter {
>>I take it you've filed a bug on toolkit for this?
>There is bug 285508 (core: xul).
No, I don't mean specifically using -moz-appearance, just toolkit styling that looks reasonable on the Mac.

Comment 11

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/543365d1eca0