Closed Bug 517788 Opened 12 years ago Closed 12 years ago

[Mac Classic] Download Manager polish

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(3 files)

The progress meters used in trees has no native look at all. The black progress bar looks terrible on mac. We should at least try to mimic some of the colors in native progress bars (since -moz-appearance: progressbar won't work)
This patch also fixes the button and the search field (makes them smaller). For the search field, I use the "compact" class - only affects mac (see textbox.css in toolkit). I also made some tweaks of the progressDialog (why is it a window?). Screenshots coming up.
Attachment #401740 - Flags: superreview?
Attachment #401740 - Flags: review?(mnyromyr)
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0
Here are some screenshots. From top to bottom: Before - aqua - graphite - diabled.
Comment on attachment 401741 [details]
Screenshots, download manager before - after

Note: the "Clear List" button might have changed its vertical position with 1px since I did thit screenshot
Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Seems I slipped when requesting this...
Attachment #401740 - Flags: superreview? → superreview?(neil)
Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Whew, the old progressmetres were truly scary!

>diff --git a/suite/common/downloads/progressDialog.xul b/suite/common/downloads/progressDialog.xul
>+<window id="dlProgressWindow"
>+        xmlns:html="http://www.w3.org/1999/xhtml"
>         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"

Please move the default namespace before the html one.


r=me with that.
Attachment #401740 - Flags: review?(mnyromyr) → review+
Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

>+/* There's no way this will look like a native progressbar, but we can at least
>+   try to mimic the aqua, graphite and non-active colors. */
>+treechildren::-moz-tree-progressmeter {
I take it you've filed a bug on toolkit for this?
Attachment #401740 - Flags: superreview?(neil) → superreview+
(In reply to comment #7)
> (From update of attachment 401740 [details] [diff] [review])
> >+/* There's no way this will look like a native progressbar, but we can at least
> >+   try to mimic the aqua, graphite and non-active colors. */
> >+treechildren::-moz-tree-progressmeter {
> I take it you've filed a bug on toolkit for this?

There is bug 285508 (core: xul).
Attachment #401740 - Flags: approval-seamonkey2.0?
Comment on attachment 401740 [details] [diff] [review]
polish downloadmanager

Low-risk, download manager mac theme enhancements.
(In reply to comment #8)
>(In reply to comment #7)
>> (From update of attachment 401740 [details] [diff] [review])
>>>+/* There's no way this will look like a native progressbar, but we can at least
>>>+   try to mimic the aqua, graphite and non-active colors. */
>>>+treechildren::-moz-tree-progressmeter {
>>I take it you've filed a bug on toolkit for this?
>There is bug 285508 (core: xul).
No, I don't mean specifically using -moz-appearance, just toolkit styling that looks reasonable on the Mac.
Attachment #401740 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
http://hg.mozilla.org/comm-central/rev/543365d1eca0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.