517864 - Reclaim vertical space in the bookmarks toolbar menu

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Philip Chee]

In Bug 407048 stefan removed several rules from the modern bookmarksToolbar.css because, being a Mac person, he didn't understand why they were needed. Unfortunately this caused the vertical bookmark menus (bookmark toolbarbutton and Personal toolbar bookmarks) to stretch vertically - and also lose the dropmarker effect.

Adding back these rules reclaims the wasted vertical space and also brings back the dropmarker.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Restore missing styles.

>  and also brings back the dropmarker.
*in modern only*

Comment 2

[Philip Chee]

KaiRo: Bug 419178 for restoring the bookmarks menu dropmarker in classic has wanted-2.0+ so requesting the same for this bug which brings back the drop marker in Modern.

Comment 3

[Stefan [:stefanh]]

Comment on attachment 401826 [details] [diff] [review]
Patch v1.0 Restore missing styles.

So, this brings back the 1px up/down movement in Modern. Is that what you want?

Comment 4

[Stefan [:stefanh]]

(In reply to comment #3)
> (From update of attachment 401826 [details] [diff] [review])
> So, this brings back the 1px up/down movement in Modern. Is that what you want?

(it's not very nice imo)

Comment 5

[Stefan [:stefanh]]

(In reply to comment #0)
> In Bug 407048 stefan removed several rules from the modern bookmarksToolbar.css
> because, being a Mac person, he didn't understand why they were needed.

Maybe you can explain why they're needed because I don't see any difference, except that for the 1px up/down movement.

Comment 6

[Stefan [:stefanh]]

Actually, by reading the firefox bug I now finally understand what a dropmarker (in this context) is. But I see it even if I don't apply your patch.

Comment 7

[[e-mail]]

Comment on attachment 401826 [details] [diff] [review]
Patch v1.0 Restore missing styles.

>+  padding: 1px 3px 1px 2px;
Reduced top and bottom padding is nice, but we'd better stick with the existing 2px right padding (which conveniently means that you can use the 2-arg shorthand).

>+  margin-top: -1px;
stefanh jogged my memory as to why we can't use margin-top: -1px; - it makes the arrowscrollbox think that the menu is scrollable. If you really think we need this we could probably work around it using :first-child or something.

Comment 8

[Philip Chee]

> Actually, by reading the firefox bug I now finally understand what a dropmarker
> (in this context) is. But I see it even if I don't apply your patch.

On my WinXP notebook (luna xp theme), without the -1px top margin, the horizontal drop line is invisible.

> stefanh jogged my memory as to why we can't use margin-top: -1px; - it makes
> the arrowscrollbox think that the menu is scrollable. If you really think we

Ah, Multizilla adds a "Open folder in tabs" menuitem at the top of each popup so I never saw this in my XPFE profile.

> need this we could probably work around it using :first-child or something.

I ran around in circles for a while until I realized it should be :second-child :P

New patch coming up.

Comment 9

[Philip Chee]

That's very strange. Now I see the horizontal drop line even without the -1px margin....

Comment 10

[Philip Chee]

Attachment: Patch 1.1 Fix padding only

>>+  padding: 1px 3px 1px 2px;
> Reduced top and bottom padding is nice, but we'd better stick with the existing
> 2px right padding (which conveniently means that you can use the 2-arg
> shorthand).
Fixed.

> On my WinXP notebook (luna xp theme), without the -1px top margin, the
> horizontal drop line is invisible.
[...]
> That's very strange. Now I see the horizontal drop line even without the -1px
> margin....
removed -1px top-margin from the patch.

Comment 11

[[e-mail]]

Comment on attachment 402021 [details] [diff] [review]
Patch 1.1 Fix padding only

[The :first-child is the one that doesn't want the -1px margin.]

Comment 12

[[e-mail]]

Actually I wonder whether we should do this for all iconic menu(item)s...

Comment 13

[Philip Chee]

> [The :first-child is the one that doesn't want the -1px margin.]
The menu only stopped jumping up/down by 1px if I applied the :not() rule to the second child.

menu.bookmark-item:not(:second-child) { margin-top: -1px; }.

The first child seems to always have a css rule of { display: none; }

Comment 14

[Frank Wein [:mcsmurf]]

http://hg.mozilla.org/comm-central/rev/e4323e0a3390