517978 - Replace Protovis with D3.js

Status: RESOLVED WONTFIX

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

Protovis 3.0 is in.  We should make sure our code works w/ it, and upgrade the shipped version to be it.

Comment 1

[David Ascher (:davida)]

assigning to me so i don't lose track of it, but would be more than happy for someoene else to get to it.

Comment 2

[Nomis101]

Protovis is no longer under active development since 2011. And it is recommended to switching to D3.js. So, is this bug still valid?

Comment 3

[Jim Porter (:squib)]

It's still valid in the sense that Protovis 2.x should be eliminated. Updating the bug title. I'm happy to help anyone who wants to work on this.

Comment 4

[Nomis101]

Attachment: Just replace it...

This simply replaces the current protovis with d3. I'm not sure what else is needed here. I've made a build with this patch and tested Gloda, which seems to work. How can I test this further?

Comment 5

[Jim Porter (:squib)]

The big thing to test out is the bar graph in Gloda.

Comment 6

[Nomis101]

Oh! There is no bar graph at all with this patch. :-(

Comment 7

[Nomis101]

If I start Gloda, this error pops up in the error console:

Zeitstempel: 16.12.14 23:50:52
Fehler: DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
resource://gre/components/nsSearchService.js 2928 SRCH_SVC__ensureInitialized
resource://gre/components/nsSearchService.js 4218 SearchService.prototype.currentEngine
chrome://messenger/content/webSearch.xml 42 _adjustAcItem
chrome://messenger/content/webSearch.xml 22 websearch_XBL_Constructor
chrome://gloda/content/glodacomplete.xml 59 _appendCurrentResult
chrome://gloda/content/glodacomplete.xml 79 _invalidate
chrome://global/content/bindings/autocomplete.xml 995 _openAutocompletePopup
chrome://global/content/bindings/autocomplete.xml 977 openAutocompletePopup
chrome://global/content/bindings/autocomplete.xml 348 openPopup
chrome://global/content/bindings/autocomplete.xml 94 set_popupOpen
resource://gre/components/glautocomp.js 98 ACGR_announceYourself
resource://gre/components/glautocomp.js 525 nsAutoCompleteGloda.prototype.startSearch
null 0 null

Quelldatei: resource:///modules/Deprecated.jsm
Zeile: 79

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

That sounds like it's unrelated and is the "Search Bing for:" thing that got added at some point.

Looking at the patch, it just seems to replace protovis with d3.  The good news/bad news is that d3 has a much more intuitive execution model (good news!), the bad news is it has a very different execution model/API (bad news), so it's not a drop-in replacement.  (Protovis 3.0 probably would have worked transparently; d3 is very different, but better.)

It likely makes sense to wait until there's a reason to switch to d3, like landing other code that uses d3.  For example, :squib's extension that does the account summary stuff with cool graphs.

Comment 9

[Jim Porter (:squib)]

(In reply to Andrew Sutherland [:asuth] from comment #8)
> It likely makes sense to wait until there's a reason to switch to d3, like
> landing other code that uses d3.  For example, :squib's extension that does
> the account summary stuff with cool graphs.

That's part of why I want this to land. :) (Mail Summaries currently uses Protovis, but I've had to employ quite a few hacks to make it do what I want.)

Comment 10

[:aceman]

So this does not look like an easy bug.

Also I think there are some graphs in the Filelink account settings (for attachment sending).

Also, could we please push these 3rd party libraries into a separate directory?

squib, if you know how to work with the library, it would be best if you do the conversion.

Comment 11

[Jim Porter (:squib)]

I'm not likely to have time to work on anything Thunderbird-related for the foreseeable future, sorry.

Comment 12

[:aceman]

There may also be the possibility to drop protovis/D3 from TB, if it is just used for some simple pie chart in Filelink disk space indicator. There is also some use in Gloda search, maybe the message count statistics on the top of the page. If we just need simple bars, those could be implemented in XHTML in some way.

Comment 13

[Magnus Melin [:mkmelin]]

No plans for this.