Closed
Bug 517997
Opened 14 years ago
Closed 14 years ago
use larger icons for search providers
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(fennec1.0+)
VERIFIED
FIXED
fennec1.0b5
Tracking | Status | |
---|---|---|
fennec | 1.0+ | --- |
People
(Reporter: madhava, Assigned: mfinkle)
Details
(Whiteboard: [polish])
Attachments
(6 files, 2 obsolete files)
Given that, in bug 516959, we're making the search bar taller, the buttons will accommodate larger icons. For the default search providers, instead of scaling up 16px favicons, we should use icons at the real size. We can/should also use the right size icons for search providers' rows in the add-ons manager. I'm gathering these icons at 24px and 32px sizes.
Reporter | ||
Updated•14 years ago
|
Whiteboard: [polish]
Reporter | ||
Comment 1•14 years ago
|
||
Reporter | ||
Updated•14 years ago
|
Flags: wanted-fennec1.0?
Reporter | ||
Comment 2•14 years ago
|
||
Reporter | ||
Comment 3•14 years ago
|
||
Looking into getting icons for Twitter Search now, as well.
Comment 4•14 years ago
|
||
Have we made a request with Twitter asking if it's ok to incorporate as a default? If not, I'll take that as well.
Comment 5•14 years ago
|
||
(In reply to comment #4) > Have we made a request with Twitter asking if it's ok to incorporate as a > default? If not, I'll take that as well. Yes, twitter has approved being included as a search engine on Fennec.
Reporter | ||
Comment 6•14 years ago
|
||
To be clear - the 24px versions are for the searchbar buttons and the 32px ones are for the add-ons manager rows about the search providers. In both places, for non-default providers, we should blow up the favicons to these sizes (we do this at the moment in the add-ons manger).
Reporter | ||
Updated•14 years ago
|
tracking-fennec: --- → ?
Priority: -- → P2
Updated•14 years ago
|
tracking-fennec: ? → 1.0+
Assignee | ||
Comment 7•14 years ago
|
||
I don't think we can use different icon sizes in the same provider. One icon only. I'll use the 24px images since they are the ones seen most often. They will also scale to 32px a little better than the current 16px images too.
Assignee | ||
Comment 8•14 years ago
|
||
patch in bug 516959
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → mark.finkle
Reporter | ||
Comment 9•14 years ago
|
||
I think we should include the 32px ones, given that the search bar will scale them down to 24px. Scaling down looks better than scaling up. I think this is what the patch mentioned in comment 8 does anyway.
Assignee | ||
Comment 10•14 years ago
|
||
pushed 32px images as part of bug 516959
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → B5
Comment 11•14 years ago
|
||
Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though. verified FIXED on builds: Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026 Fennec/1.0b5pre and Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026 Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 12•14 years ago
|
||
(In reply to comment #11) > Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though. Yeah - we're still waiting on getting actual 32px icons from amazon, twitter, and wikipedia.
Reporter | ||
Comment 13•14 years ago
|
||
Assignee | ||
Comment 14•14 years ago
|
||
This patch updates the wikipedia image
Attachment #408894 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Attachment #408894 -
Flags: review?(gavin.sharp) → review+
Reporter | ||
Comment 15•14 years ago
|
||
Reporter | ||
Comment 16•14 years ago
|
||
so that's just amazon.com that's needed still
Comment 17•14 years ago
|
||
I'll try and get this by tomorrow. They're working on it.
Comment 18•14 years ago
|
||
Here's the favicon Amazon sent. Note that it does not have the white background any longer. Not sure how it will look, so if you could let me know whether we should re-request with the background, that'd be great.
Reporter | ||
Comment 19•14 years ago
|
||
Attachment #409954 -
Attachment is obsolete: true
Reporter | ||
Comment 20•14 years ago
|
||
Attachment #409970 -
Attachment is obsolete: true
Comment 21•14 years ago
|
||
Updated amazon and twitter: https://hg.mozilla.org/mobile-browser/rev/c36f699ca051
Comment 22•14 years ago
|
||
Comment on attachment 408894 [details] [diff] [review] patch (wikipedia) >--- a/locales/en-US/searchplugins/wikipedia.xml >+++ b/locales/en-US/searchplugins/wikipedia.xml >-<Image width="16" height="16"> >+<Image width="16" height="16"> Hey, I need a quick advice here. If the icon size has changed, shouldn't we change the width and height attributes of the <Image/> element? The patch didn't do that, and I'm just wondering if localizers shouldn't as well. Thanks.
Assignee | ||
Comment 23•14 years ago
|
||
(In reply to comment #22) > Hey, I need a quick advice here. If the icon size has changed, shouldn't we > change the width and height attributes of the <Image/> element? The patch > didn't do that, and I'm just wondering if localizers shouldn't as well. IIRC, when I tried that, no image was loaded. The search provider code may only expect <Image width="16" height="16"> images, but reads in the true image, whatever the size. I could be misremembering though.
Comment 24•14 years ago
|
||
Yeah, the search service only loads 16x16px images unfortunately. We should probably have it _prefer_ 16x16px images but fall back to other images if none are present.
Comment 25•14 years ago
|
||
I filed bug 531207.
Comment 26•14 years ago
|
||
Mark, Gavin, thanks for clarifying. We will continue to use <Image width="16" height="16"> in the plug-ins for now.
You need to log in
before you can comment on or make changes to this bug.
Description
•