use larger icons for search providers

VERIFIED FIXED in fennec1.0b5

Status

Fennec Graveyard
General
P2
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: madhava, Assigned: mfinkle)

Tracking

Trunk
fennec1.0b5
x86
Mac OS X
Bug Flags:
wanted-fennec1.0 ?

Details

(Whiteboard: [polish])

Attachments

(6 attachments, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Given that, in bug 516959, we're making the search bar taller, the buttons will accommodate larger icons.  For the default search providers, instead of scaling up 16px favicons, we should use icons at the real size.

We can/should also use the right size icons for search providers' rows in the add-ons manager.

I'm gathering these icons at 24px and 32px sizes.
(Reporter)

Updated

8 years ago
Whiteboard: [polish]
(Reporter)

Comment 1

8 years ago
Created attachment 402359 [details]
yahoo icon set
(Reporter)

Updated

8 years ago
Flags: wanted-fennec1.0?
(Reporter)

Comment 2

8 years ago
Created attachment 403575 [details]
google icon set
(Reporter)

Comment 3

8 years ago
Looking into getting icons for Twitter Search now, as well.

Comment 4

8 years ago
Have we made a request with Twitter asking if it's ok to incorporate as a default? If not, I'll take that as well.
(In reply to comment #4)
> Have we made a request with Twitter asking if it's ok to incorporate as a
> default? If not, I'll take that as well.

Yes, twitter has approved being included as a search engine on Fennec.
(Reporter)

Comment 6

8 years ago
To be clear - the 24px versions are for the searchbar buttons and the 32px ones are for the add-ons manager rows about the search providers.  In both places, for non-default providers, we should blow up the favicons to these sizes (we do this at the moment in the add-ons manger).
(Reporter)

Updated

8 years ago
tracking-fennec: --- → ?
Priority: -- → P2

Updated

8 years ago
tracking-fennec: ? → 1.0+
I don't think we can use different icon sizes in the same provider. One icon only. I'll use the 24px images since they are the ones seen most often. They will also scale to 32px a little better than the current 16px images too.
patch in bug 516959
(Assignee)

Updated

8 years ago
Assignee: nobody → mark.finkle
(Reporter)

Comment 9

8 years ago
I think we should include the 32px ones, given that the search bar will scale them down to 24px.  Scaling down looks better than scaling up.  I think this is what the patch mentioned in comment 8 does anyway.
pushed 32px images as part of bug 516959
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Target Milestone: --- → B5
Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though.

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
(Reporter)

Comment 12

8 years ago
(In reply to comment #11)
> Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though.

Yeah - we're still waiting on getting actual 32px icons from amazon, twitter, and wikipedia.
(Reporter)

Comment 13

8 years ago
Created attachment 408694 [details]
wikipedia icons (two options)
Created attachment 408894 [details] [diff] [review]
patch (wikipedia)

This patch updates the wikipedia image
Attachment #408894 - Flags: review?(gavin.sharp)
Attachment #408894 - Flags: review?(gavin.sharp) → review+
(Reporter)

Comment 15

8 years ago
Created attachment 409107 [details]
twitter icon 32px
(Reporter)

Comment 16

8 years ago
so that's just amazon.com that's needed still

Comment 17

8 years ago
I'll try and get this by tomorrow. They're working on it.

Comment 18

8 years ago
Created attachment 409954 [details]
Amazon 32px favicon

Here's the favicon Amazon sent. Note that it does not have the white background any longer. Not sure how it will look, so if you could let me know whether we should re-request with the background, that'd be great.
(Reporter)

Comment 19

8 years ago
Created attachment 409970 [details]
on a rounded white background, like wikipedia
Attachment #409954 - Attachment is obsolete: true
(Reporter)

Comment 20

8 years ago
Created attachment 409978 [details]
better version
Attachment #409970 - Attachment is obsolete: true
Updated amazon and twitter:
https://hg.mozilla.org/mobile-browser/rev/c36f699ca051
Comment on attachment 408894 [details] [diff] [review]
patch (wikipedia)

>--- a/locales/en-US/searchplugins/wikipedia.xml
>+++ b/locales/en-US/searchplugins/wikipedia.xml

>-<Image width="16" height="16">
>+<Image width="16" height="16">

Hey, I need a quick advice here. If the icon size has changed, shouldn't we change the width and height attributes of the <Image/> element? The patch didn't do that, and I'm just wondering if localizers shouldn't as well.

Thanks.
(In reply to comment #22)

> Hey, I need a quick advice here. If the icon size has changed, shouldn't we
> change the width and height attributes of the <Image/> element? The patch
> didn't do that, and I'm just wondering if localizers shouldn't as well.

IIRC, when I tried that, no image was loaded. The search provider code may only expect <Image width="16" height="16"> images, but reads in the true image, whatever the size.

I could be misremembering though.
Yeah, the search service only loads 16x16px images unfortunately. We should probably have it _prefer_ 16x16px images but fall back to other images if none are present.
I filed bug 531207.
Mark, Gavin, thanks for clarifying. We will continue to use <Image width="16" height="16"> in the plug-ins for now.
You need to log in before you can comment on or make changes to this bug.