Closed Bug 517997 Opened 11 years ago Closed 11 years ago

use larger icons for search providers

Categories

(Firefox for Android Graveyard :: General, defect, P2)

x86
macOS
defect

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0b5
Tracking Status
fennec 1.0+ ---

People

(Reporter: madhava, Assigned: mfinkle)

Details

(Whiteboard: [polish])

Attachments

(6 files, 2 obsolete files)

Given that, in bug 516959, we're making the search bar taller, the buttons will accommodate larger icons.  For the default search providers, instead of scaling up 16px favicons, we should use icons at the real size.

We can/should also use the right size icons for search providers' rows in the add-ons manager.

I'm gathering these icons at 24px and 32px sizes.
Whiteboard: [polish]
Attached file yahoo icon set
Flags: wanted-fennec1.0?
Attached file google icon set
Looking into getting icons for Twitter Search now, as well.
Have we made a request with Twitter asking if it's ok to incorporate as a default? If not, I'll take that as well.
(In reply to comment #4)
> Have we made a request with Twitter asking if it's ok to incorporate as a
> default? If not, I'll take that as well.

Yes, twitter has approved being included as a search engine on Fennec.
To be clear - the 24px versions are for the searchbar buttons and the 32px ones are for the add-ons manager rows about the search providers.  In both places, for non-default providers, we should blow up the favicons to these sizes (we do this at the moment in the add-ons manger).
tracking-fennec: --- → ?
Priority: -- → P2
tracking-fennec: ? → 1.0+
I don't think we can use different icon sizes in the same provider. One icon only. I'll use the 24px images since they are the ones seen most often. They will also scale to 32px a little better than the current 16px images too.
Assignee: nobody → mark.finkle
I think we should include the 32px ones, given that the search bar will scale them down to 24px.  Scaling down looks better than scaling up.  I think this is what the patch mentioned in comment 8 does anyway.
pushed 32px images as part of bug 516959
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though.

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre
Status: RESOLVED → VERIFIED
(In reply to comment #11)
> Yep, they're bigger. Some of them are kinda ugly like (i.e. twitter) though.

Yeah - we're still waiting on getting actual 32px icons from amazon, twitter, and wikipedia.
This patch updates the wikipedia image
Attachment #408894 - Flags: review?(gavin.sharp)
Attachment #408894 - Flags: review?(gavin.sharp) → review+
Attached image twitter icon 32px
so that's just amazon.com that's needed still
I'll try and get this by tomorrow. They're working on it.
Attached image Amazon 32px favicon (obsolete) —
Here's the favicon Amazon sent. Note that it does not have the white background any longer. Not sure how it will look, so if you could let me know whether we should re-request with the background, that'd be great.
Attachment #409954 - Attachment is obsolete: true
Attached image better version
Attachment #409970 - Attachment is obsolete: true
Comment on attachment 408894 [details] [diff] [review]
patch (wikipedia)

>--- a/locales/en-US/searchplugins/wikipedia.xml
>+++ b/locales/en-US/searchplugins/wikipedia.xml

>-<Image width="16" height="16">
>+<Image width="16" height="16">

Hey, I need a quick advice here. If the icon size has changed, shouldn't we change the width and height attributes of the <Image/> element? The patch didn't do that, and I'm just wondering if localizers shouldn't as well.

Thanks.
(In reply to comment #22)

> Hey, I need a quick advice here. If the icon size has changed, shouldn't we
> change the width and height attributes of the <Image/> element? The patch
> didn't do that, and I'm just wondering if localizers shouldn't as well.

IIRC, when I tried that, no image was loaded. The search provider code may only expect <Image width="16" height="16"> images, but reads in the true image, whatever the size.

I could be misremembering though.
Yeah, the search service only loads 16x16px images unfortunately. We should probably have it _prefer_ 16x16px images but fall back to other images if none are present.
Mark, Gavin, thanks for clarifying. We will continue to use <Image width="16" height="16"> in the plug-ins for now.
You need to log in before you can comment on or make changes to this bug.