518106 - change crumbled paper to flame for junk column

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Andreas Nilsson (:andreasn)]

The only place we still use the crumbled paper in the Aero theme is the column header, we need to change that to a flame.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue

Comment 2

[Phil Ringnalda (:philor)]

You mean in Qute (and thus in Qute-Aero since it doesn't override any of them), right?

And you mean "one of the two places we still use the crumpled paper" since we also still have it for /icons/junk.png (used in the notification bar when you view a message marked as junk), right?

And you mean "one of the three places we need a flame icon" since primaryToolbar.css sets #junkIcon to /icons/folder-junk.png in all three themes, even though it only exists in Pinstripe, so Qute and Gnomestripe say "Messages that &brandShortName; thinks are junk will display a junk icon." in the dialog you get the first time you mark something as junk, while Pinstripe says "Messages that &brandShortName; thinks are junk will display a junk icon {image that shows what the icon looks like}.", right?

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 402076 [details] [diff] [review]
patch to fix the issue

But I'm going to _love_ that next patch :)

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: hope this patch works better

This patch implement different graphics for xp and aero and adds a flame for the folder in xp

Comment 5

[Andreas Nilsson (:andreasn)]

Note that the graphics used for junk(s).png is 24x24 instead of 32x32 in order to make the yellow stripe slightly smaller to give more space for the message preview.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 402873 [details] [diff] [review]
hope this patch works better

Yup, that works fine, thanks.

I'll file another bug on the lack of the oddly-named folder-junk.png in qute and gnomestripe.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 402873 [details] [diff] [review]
hope this patch works better

i was slow and your patch bit-rotted. :(   just the jar.mn file of course!

Since I had to update it to take a look I'll post the updated version.  Everything looks good.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: unbit-rotted

here's the updated version

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/e135102e93a5