518128 - hang on saved search, group by sort, views that does not mach any msg

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[ovidiu]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090915 Thunderbird/3.0b4

On a ssearch, grouped by sort, select a view that would result in no msg shown. It shows the group header and freezes. Normal behavior in normal folders.


STR
-have a saved search, mine had 98 msg in it
-say group by sort, it does
-have the views widget in the toolbar
-select various views, unread, important etc
-select one that would result in nothing to show or make a custom one with several criteria

result: hang, have to kill app
-shows the collapsed group (old mail) and on click hangs
expect: show blanc tree ...

repro: always

nothing in error console, if it had any time to show...

Comment 1

[David :Bienvenu]

I've tried these steps w/o a problem, so there must be something more specific required in the STR.

Comment 2

[ovidiu]

It seams limited to a certain folder to be searched (by saved search). Or may be that exact folder that I spoiled with bug 517467 and had to reindex. A gmail imap inbox.

I can grant you access to that imap as it is testing tb only.

Otherwise problem seam broader than this. (or narrower) 
1. I just got same with qsearching and certain steps over grouped ssearch
2. I already had bug 517467 and see comments, maybe that spoiled something or opened some pandora's (group) box


I'll try this on another (xp) machine to see.



For the views I think you have to play with those criteria a bit, maybe make a custom view. It may be narrower to tags or a certain sequence I did not found yet. It does not occur immediately or consistently, but eventually does.


The new qsearch specific case:
-saved search, grouped by sort
!-write in the qserch a term like "bug." (bug period)
!-do not actually search
!-do attempt to 
-change qsearch dropdown to "Subject or from" or another
repro three times the same 

it seamed to me important to have that "." in the search text, it just got the result immediately, while the term "bug" did not

Comment 3

[ovidiu]

I limited this to certain imap  and only this machine and profile.

wfm on an xp with Mozilla/5.0 Gecko/20090921 or on other folders to be searched


crashes:
ce00fea6-7d53-454e-9270-fd3ff2090922	
(saved search, gbys, view with a custom view)

633c03fe-5626-4ea7-a7e8-0d4b52090922
(saved search, g by s, view with a custom view -that would show nothing?, crash precisely when clicked the twisty on the group header)

Comment 4

[ovidiu]

Attachment: Frozen UI if change serch criteria during dropdown appear

On a completely new profile tried this and that, seams more ok, nut eventually frozen.

saved search, group by sort, type "la", change search to Subject and from
I think I id this several times before got it. THe capture shows the state where things freeze, by the time dropdown appeared and I changed search crit with it opened. It actually remained the only part "active" in the ui.

Comment 5

[Wayne Mery (:wsmwk)]

Tony, Aureliano can you confirm?

Comment 6

[[:Aureliano Buendía]]

I cannot reproduce with STR in comment #0.

With STR in comment #2 I havce a crash (Id= 9f0c0e0c-1f35-4a33-b60a-4917f2091022) also in safe mode if after a fill "bug." and change on filter "subject and from" I click on "+\-" (icon expand\collapse) icon on message list.

(In safe-mode crash Id = 044bb85b-072f-47ff-aa2d-b8df92091022)

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to comment #6)

> (In safe-mode crash Id = 044bb85b-072f-47ff-aa2d-b8df92091022)

https://bugzilla.mozilla.org/show_bug.cgi?id=519771 was fixed - but it's a "open" signature crash. Aureliano - do you crash everytime you do str from comment #2 ?

Comment 8

[[:Aureliano Buendía]]

(In reply to comment #7)
> Aureliano - do you crash everytime you do str from
> comment #2 ?

Yes it is.

STR:
1. start TB in safe-mode;
2. go to view "All Folders"
3. create a saved search (I create a saved search base on my TBbugzilla with fiter condition <subject> <contains> <bug>: all 2019 mails are selected);
4. sort saved search group by sort (date descending) and fill "bug." (without quotes) on globalsearch when is applied "search all messages" and don't raise search;
5. change filter on globalsearch to "Subject or From" (zero results);
6. in message pane click on "+\-" icon (one or two time): crash!

last crash Id =6028716c-e625-4a56-b756-e58a82091023

Comment 9

[David :Bienvenu]

I have a reproducible hang in a qs of a smart folder, along with a fix.

Comment 10

[David :Bienvenu]

marking blocking - the hang I see is if we have two msg hdrs with the same msg key in a group, and then do a quick search.

Comment 11

[David :Bienvenu]

Attachment: fix for hang I saw

If you had two headers with the same key in a cross-folder group, and are looking for the second one, FindMsgHdr hangs, because we're not advancing the index to start looking at when the folders don't match.

Comment 12

[David :Bienvenu]

I reproduced this hang by clicking on my smart drafts folder, grouping by date, and doing a quick search. We hung trying to remove bad hits from the cached results, so this bug is kinda similar to bug 524064, in that we shouldn't be using the cached results in the first place, but the code should work in any case.

Comment 13

[David :Bienvenu]

Comment on attachment 408471 [details] [diff] [review]
fix for hang I saw

this isn't quite right - new patch upcoming

Comment 14

[David :Bienvenu]

Attachment: better fix

Comment 15

[David :Bienvenu]

I've been trying to test this with the dbviewwrapper tests, but I haven't been able to get it to fail in crashing/hanging ways. I'm thinking I'll just add a test to test_nsMsgDBView.js that creates a cross folder saved search with hdrs with the same keys in multiple local folders, turns on grouping, and verifies that we can remove a header from the group thread (retrieved via nsIMsgDBView::getThreadContainingIndex()).

Comment 16

[David :Bienvenu]

Attachment: need to init index

3rd times the charm?

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 409105 [details] [diff] [review]
need to init index

This appears to be an improvement, though I'm still seeing a few crashes with similar steps on cross-folder/account views. I think we can deal with those separately.

Comment 18

[Mark Banner (:standard8)]

Oh I should have said there was a bit of bitrot on this as you've got two patches applied on top of each other.

Comment 19

[David :Bienvenu]

fix on trunk and 3.0 branch. sorry for the bitrot.