518135 - mouse up in a Cocoa event model plugin generates an event of unrecognized type

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

Mouse up in a Cocoa event model plugin causes an event of unrecognized type (0) to be sent to the plugin.

Comment 1

[Josh Aas]

Attachment: fix v1.0

If we receive an event without a native event attached and we don't care about it we send a bogus event to the plugin. We should bail instead, ignoring the event. We can test for this in bug 518278.

Comment 2

[Josh Aas]

Comment on attachment 402434 [details] [diff] [review]
fix v1.0

Actually we might not want to do this. It doesn't correctly match start/end draw calls.

Comment 3

[Josh Aas]

Attachment: fix v1.1

Comment 4

[Josh Aas]

Attachment: alt fix v1.0

We could also do it like this, which avoids early returns.

Comment 5

[Josh Aas]

pushed fix v1.1 to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/c3541686e7cf

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

roc landed this on 1.9.2 yesterday, but inadvertently on a relbranch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/329b6494c800
I backed it out of the relbranch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f57f01f6b371
and relanded it on the default branch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ed9a0c476849

However, I'm a little confused about whether it was supposed to land on 1.9.2 in the first place; I don't see anything in the bug about it being intended for 1.9.2 until roc marked it as fixed for 1.9.2.2.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I landed this to fix bug 537269 on branch.

Comment 8

[Carsten Book [:Tomcat]]

Josh, is there a way to test/verify this bug ?

Comment 9

[Josh Aas]

Not easily right now. You can test other bugs it fixed, but our test plugin is only Cocoa when used in 64-bit builds right now.