Closed Bug 537269 Opened 15 years ago Closed 14 years ago

Smart navigation in Google Maps Street View is broken in Firefox 3.6* on Mac OS X

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Version:
1.9.2 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking1.9.2 needed, status1.9.2 .2-fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking1.9.2 --- needed
status1.9.2 --- .2-fixed

People

(Reporter: tbassetto, Assigned: roc)

References

(
URL
)

Details

(Keywords: verified1.9.2)

Attachments

(1 file, 2 obsolete files)

fix
1.24 KB, patch
jaas
: review+
beltzner
: approval1.9.2.2+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9.2b6pre) Gecko/20091229 Namoroka/3.6b6pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9.2b6pre) Gecko/20091229 Namoroka/3.6b6pre

As you move your mouse within Street View, the cursor has lightly-shaded geometry attached to it - it will show an oval when your mouse is following a road and a rectangle when moving across the facades of buildings.

Double-clicking on this "geometry" transports you to the best panorama in that direction.

I've tested this feature on Mac OS X Leopard with Flash 10.0.42.34 and Firefox 3.6 beta 1, beta 2, beta 3, beta 4 and the today nightly. On each version I used a completely new profile and each time the smart navigation didn't work.

However, with the same OS and the same version of Flash plugin it works on Firefox 3.5.6.

Reproducible: Always

Steps to Reproduce:
1. Go to http://maps.google.com
2. Drag the yellow men icon to a road outlined in blue (in order to launch the Street Maps view)
3. Double-click on the white rounded geometry that appears around you cursor.
Actual Results:  
Nothing happen. Maybe the geometry will "bounce" slightly.

Expected Results:  
A zoom to the location of the geometry.
This WFM with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091230 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091230042231
It seems that the bug appears only on Mac OS X and the 3.6 branch.

I've just tested with the latest en-US nightly (i.e. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091230 Minefield/3.7a1pre) and a new profile: the bug is _not_ present!

So I've downloaded the latest en-US 3.6 branch (i.e. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b6pre) Gecko/20091230 Namoroka/3.6b6pre) and I've created a new profile again. The bug _is present_!

PS: just in case I was not clear enough, when I talk about geometries and smart navigation: http://google-latlong.blogspot.com/2009/06/introducing-smart-navigation-in-street.html
Version: unspecified → 3.6 Branch
Attached image screenshot of the situation (obsolete) — 
This position is a double click insensitive spot. After double clicking the map will stick to the pointer.
So there are two problems: the insensitive spot, and the dragging after the second mouseup.
So confirmed with latest trunk on Windows Vista. Double clicking has sometimes not the intended result.
Status: UNCONFIRMED → NEW
Component: General → Plug-ins
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → plugins
Version: 3.6 Branch → 1.9.2 Branch
Thomas, do you have dom.ipc.plugins.enabled to true? Then indeed it doesn't work at all.

For the drag issue I filed: Bug 537309.
"dom.ipc.plugins.enabled" doesn't appear when I search it in about:config so I don't know its (default) value.
dom.ipc.plugins.enabled doesn't exist on 1.9.2 yet.
Yeah sorry, it is a trunk only pref, I was sleeping.
On Windows it is not a regression; I see it also with old Firefox 2, so it is not likely that we're talking about the same bug.
This needs to be confirmed by someone on a Mac with the latest Firefox 3.6.
Status: NEW → UNCONFIRMED
Ever confirmed: false
CCing Tomcat, Tomcat can you test that bug on a mac? It is a possible Mac-only regression on the 3.6 branch. Thanks
I can confirm this bug. I first see it appeared on the beta 4 (as I did not test previous beta, I can not tell). The situation was worse in beta 4 due to Bug 516602. 
I have tested on Windows XP, but all is fine on this platform. Hence it is a Mac-only bug.
Marking New as per Vincent's feedback, thanks
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #419605 - Attachment is obsolete: true
If Street View broken on a Mac, shouldn't this block Firefox 3.6?
Flags: blocking1.9.2?
I managed to reproduce this on 3.6 on Mac, but wasn't able to reproduce this on trunk.
blocking1.9.2: --- → ?
Flags: blocking1.9.2?
Is this a regression?
Using the testcase in comment 15, i started looking for a regression.  

interesting enough, it works fine on the Fx3.6rc: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6.  also works on trunk as others have mentioned.  

but its broken on 1.9.2 nightly: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2pre) Gecko/20100115 Namoroka/3.6pre

i'll look for a regression range on the 1.9.2 branch.
Sorry, meant, was this regressed by bug 537309
The patch in bug 537309 only affected Windows, could not have affected Mac.
I've found a blog post where people seem to have the same sort of bug. They provide a lot more technical information: http://blog.zoomodev.com/post/2010/01/22/Firefox-3.6-plugin-regression

Quote:
"When you do click on a swf node in firefox 3.6, flash then successively receive a notification that the mouse has moved from its previous position (x, y), to (x - window.screenX, y - window.screenY), and immediately after, back to (x, y)".
I'm the author of the mentioned blog post.


See http://livedocs.adobe.com/flash/9.0/ActionScriptLangRefV3/flash/display/InteractiveObject.html#event:doubleClick

"For a doubleClick event to occur, it must immediately follow the following series of events: mouseDown, mouseUp, click, mouseDown, mouseUp."

I just tested it: you don't get double-clicks anymore with 3.6 (on the flash-side), because you get extraneous mouse events just after a click - the mouse is suddenly offset-ed, then brought back to its correct position, which triggers either a mouseOut/rollOut (then a mouseOver/rollOver with the next user interaction), or a mouseMove, mouseOut/rollOut, mouseMove, mouseOver/rollOver.
It *seems* to me that the value of the offset matches window.screenX/Y.

I have no idea what Street View does with UI events, but I guess I'm talking about the same problem - either way, that can't help them.

I can provide ActionScript test cases if there is a need (which I doubt - I guess this can be tested in Gecko more easily).
FWIW, here is an ActionScript snippet to workaround the effects of this bug, until a fix is shipped: http://blog.zoomodev.com/post/2010/01/24/Workaround-Firefox-3.6-mouse-regression

*Not* useful for users (unless someone wraps it up in a greasemonkey script and a loader for the target application), but useful for AS developers.
Assignee: nobody → roc
What we really need here is a regression range and a fix range.
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d37939b149f0 (nightly build from 2009-09-01): BROKEN

http://hg.mozilla.org/mozilla-central/rev/c99ec9f95c64 (nightly build from 2009-08-01): WORKS (that's before the 1.9.2 branch was cut)

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c7d1cd3d77a7 (first 1.9.2 nightly build, from 2009-08-13): BROKEN

This is starting to look suspiciously like it broke when we branched ... maybe someone is version sniffing ...
Jeff, in bug 520641 comment #17 you wrote
> We've introduced polling code in the player to work around the issue in current
> builds

Is it possible that that polling code is causing this bug?
http://hg.mozilla.org/mozilla-central/rev/b50beb2bef47 (nightly trunk build from 2009-08-13): BROKEN

That's interesting.

http://hg.mozilla.org/mozilla-central/rev/febec8184b02 (nightly trunk build from 2009-08-08): BROKEN

http://hg.mozilla.org/mozilla-central/rev/6673479e68ee (nightly trunk build from 2009-08-05): BROKEN

http://hg.mozilla.org/mozilla-central/rev/8795a7a9817c (nightly trunk build from 2009-08-03): WORKS

http://hg.mozilla.org/mozilla-central/rev/3ce467cf8e0d (nightly trunk build from 2009-08-04): WORKS

So the regression range is between 3ce467cf8e0d and 6673479e68ee. It's almost certainly http://hg.mozilla.org/mozilla-central/rev/22588ab14ac6.
OK Jeff, never mind about comment #27 :-).
Now to look for the fix range...

http://hg.mozilla.org/mozilla-central/rev/b7f3c1c9fb57 (nightly trunk build from 2009-12-01): WORKS

http://hg.mozilla.org/mozilla-central/rev/51710e0ba8a3 (nightly trunk build from 2009-10-01): WORKS
http://hg.mozilla.org/mozilla-central/rev/bad2d2351f7f (nightly trunk build from 2009-09-06): BROKEN

http://hg.mozilla.org/mozilla-central/rev/333967132e88 (nightly trunk build from 2009-09-19): BROKEN

http://hg.mozilla.org/mozilla-central/rev/149c3820e8a8 (nightly trunk build from 2009-09-26): WORKS

http://hg.mozilla.org/mozilla-central/rev/f6df32312266 (nightly build from 2009-09-22): BROKEN

http://hg.mozilla.org/mozilla-central/rev/8013abd85baa (nightly build from 2009-09-24): BROKEN

http://hg.mozilla.org/mozilla-central/rev/def6be3d8b6b (nightly build from 2009-09-25): WORKS

So the fix range is between 8013abd85baa and def6be3d8b6b. Almost certainly fixed by bug 518135.
Attached patch fix (obsolete) — — Splinter Review 
This is just a backport of the patch for bug 518135. I confirmed it fixes the bug on 1.9.2.
Attachment #423743 - Flags: review?(joshmoz)
Whiteboard: [needs review]
Comment on attachment 423743 [details] [diff] [review]
fix

I think you forgot to put the actual patch in this file.
Attached patch fix — — Splinter Review 
oops
Attachment #423743 - Attachment is obsolete: true
Attachment #423759 - Flags: review?(joshmoz)
Attachment #423743 - Flags: review?(joshmoz)
Attachment #423759 - Flags: review?(joshmoz) → review+
Whiteboard: [needs review] → [needs landing]
Whiteboard: [needs landing] → [needs approval]
blocking1.9.2: ? → needed
Just wanted to add that I have the "Street View" problem with OS 10.4 after upgrade to FF3.6 release.  Maps work fine in Safari, but in FF at street level, the cursor is somewhat unstable in any drag modes or in double-clicks.  When panning, if the image is grabbed somewhere near the edge, a pan can be performed only part-way across the screen.  Near the middle of screen, the panning goes unstable and dithers rapidly left-right, sometimes executes some other mode changing the view unexpectedly.  Double-click to jump forward or to zoom only works occasionally and is extremely sensitive to mouse location, as if the window is confused as to the actual mouse location.  The function may work if a precise cursor location is found through trial-and-error.  Often during a double-click, the cursor will change mode and move briefly off-side then return to the original position with a null action.

Pasted Troubleshooting Info:




  Application Basics



        Name

        Firefox



        Version

        3.6



        Profile Directory



          Show in Finder



        Installed Plugins



          about:plugins



        Build Configuration



          about:buildconfig



  Extensions



        Name



        Version



        Enabled



        ID



        Adblock Plus

        1.1.3

        true

        {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}



        CookieCuller

        1.4

        true

        {99B98C2C-7274-45a3-A640-D9DF1A1C8460}



        Exif Viewer

        1.51

        true

        exif_viewer@mozilla.doslash.org



        FoxClocks

        2.5.46

        true

        {d37dc5d0-431d-44e5-8c91-49419370caa1}



        FxIF

        0.4

        true

        {11483926-db67-4190-91b1-ef20fcec5f33}



        MR Tech Toolkit

        6.0.4

        true

        {9669CC8F-B388-42FE-86F4-CB5E7F5A8BDC}



        NoScript

        1.9.9.47

        true

        {73a6fe31-595d-460b-a920-fcc0f8843232}



        PDF Download

        3.0.0.1

        true

        {37E4D8EA-8BDA-4831-8EA1-89053939A250}



        Print Context Menu

        1.2

        true

        printcontextmenuoption@pp



        Sothink Web Video Downloader for Firefox

        5.7

        true

        {FCAB6FDD-5585-425b-95C1-5ED856F3FD08}



        Tab Mix Plus

        0.3.8.2

        true

        {dc572301-7619-498c-a57d-39143191b318}



        Xmarks

        3.4.10

        true

        foxmarks@kei.com



        Digger

        3.5.3

        true

        digger@lindemann.us



  Modified Preferences



      Name



      Value



        accessibility.typeaheadfind.flashBar

        0



        browser.history_expire_days

        4



        browser.history_expire_days.mirror

        4



        browser.history_expire_days_min

        3



        browser.link.open_newwindow.restriction

        0



        browser.places.createdSmartBookmarks

        true



        browser.places.importBookmarksHTML

        false



        browser.places.importDefaults

        false



        browser.places.leftPaneFolderId

        -1



        browser.places.migratePostDataAnnotations

        false



        browser.places.smartBookmarksVersion

        2



        browser.places.updateRecentTagsUri

        false



        browser.startup.homepage

        about:blank



        browser.startup.homepage_override.mstone

        rv:1.9.2



        browser.tabs.closeWindowWithLastTab

        false



        browser.tabs.loadInBackground

        false



        browser.tabs.selectOwnerOnClose

        false



        browser.tabs.warnOnClose

        false



        dom.disable_window_move_resize

        true



        extensions.checkCompatibility.3.5

        true



        extensions.checkCompatibility.3.6

        true



        extensions.lastAppVersion

        3.6



        font.default.x-western

        sans-serif



        font.name.sans-serif.x-western

        Trebuchet MS



        font.name.serif.x-western

        Times New Roman



        font.size.fixed.x-western

        15



        gfx.color_management.mode

        1



        network.cookie.prefsMigrated

        true



        network.protocol-handler.warn-external.itms

        false



        places.last_vacuum

        1264643310



        print.macosx.pagesetup-2

        AAAiJjw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+CjwhRE9DVFlQRSBwbGlzdCBQVUJMSUMgIi0vL0FwcGxlIENvbXB1dGVyLy9EVEQg…



        print.print_bgcolor

        true



        print.print_bgimages

        true



        print.print_command



        print.print_downloadfonts

        true



        print.print_evenpages

        true



        print.print_in_color

        true



        print.print_margin_bottom

        0.5



        print.print_margin_left

        0.5



        print.print_margin_right

        0.5



        print.print_margin_top

        0.5



        print.print_oddpages

        true



        print.print_orientation

        0



        print.print_pagedelay

        500



        print.print_paper_data

        0



        print.print_paper_height

        11.00



        print.print_paper_size

        1



        print.print_paper_size_type

        1



        print.print_paper_size_unit

        0



        print.print_paper_width

        8.50



        print.print_printer



        print.print_reversed

        false



        print.print_scaling

        0.30



        print.print_shrink_to_fit

        true



        print.print_to_file

        false



        print.print_unwriteable_margin_bottom

        46



        print.print_unwriteable_margin_left

        25



        print.print_unwriteable_margin_right

        25



        print.print_unwriteable_margin_top

        4



        privacy.item.cookies

        true



        privacy.popups.showBrowserMessage

        false



        privacy.sanitize.migrateFx3Prefs

        true



        security.dialog_enable_delay

        0



        security.disable_button.openCertManager

        false



        security.disable_button.openDeviceManager

        false



        security.warn_viewing_mixed

        false



        security.warn_viewing_mixed.show_once

        false
Comment on attachment 423759 [details] [diff] [review]
fix

a1922=beltzner
Attachment #423759 - Flags: approval1.9.2.2? → approval1.9.2.2+
Keywords: regressionwindow-wanted
Whiteboard: [needs approval] → [needs landing]
Whiteboard: [needs landing] → [needs 192 landing]
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/329b6494c800
Status: NEW → RESOLVED
Closed: 14 years ago
status1.9.2: --- → .2-fixed
Resolution: --- → FIXED
Whiteboard: [needs 192 landing]
Depends on: 518135
    verified fixed 1.9.2-2 using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6;
    en-US; rv:1.9.2.2) Gecko/20100321 Firefox/3.6.2 ID:20100321170417
Keywords: verified1.9.2
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: