Closed
Bug 518171
Opened 15 years ago
Closed 15 years ago
quick account setup breaks if you hit stop (Error: host is undefined)
Categories
(Thunderbird :: Account Manager, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: mkmelin, Assigned: bwinton)
Details
(Whiteboard: [no l10n impact])
Attachments
(1 file)
|
4.62 KB,
patch
|
mkmelin
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
In the new account setup, once it starts probing, hit stop (tried to change the server to "pop", and port to 110). Then nothing, it just spins Error: host is undefined Source File: chrome://messenger/content/accountcreation/guessConfig.js Line: 625
Flags: blocking-thunderbird3?
|
Reporter | |
Comment 1•15 years ago
|
||
(After multiple (failed/semi-failed) attempts to set up an account and change something, i have to wonder, why wasn't this done as a normal wizard? What we have if you actually need to do something other than what it suggests is not intuitive.)
|
||
Updated•15 years ago
|
Assignee: nobody → bwinton
Flags: blocking-thunderbird3? → blocking-thunderbird3+
|
||
Updated•15 years ago
|
Whiteboard: [no l10n impact]
|
Assignee | |
Comment 2•15 years ago
|
||
There's more cleanup to do in the autoconfig, but this patch should at least fix this bug. (Also, Magnus, please let me know if you would rather I ask philor to review this patch.) Thanks, Blake.
Attachment #404034 -
Flags: superreview?(bienvenu)
Attachment #404034 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•15 years ago
|
Keywords: 4xp
Whiteboard: [no l10n impact] → [no l10n impact][needs review mkmelin][needs superreview bienvenu]
|
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P1
|
||
Updated•15 years ago
|
Attachment #404034 -
Flags: superreview?(bienvenu) → superreview+
|
|
Reporter | |
Comment 3•15 years ago
|
||
Comment on attachment 404034 [details] [diff] [review] A patch to fix the undefined host. Looks ok to me. Not this bug but i noticed it flashed "password ok" after clicking finish, even though i didn't enter any password.
Attachment #404034 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Reporter | |
Updated•15 years ago
|
OS: Linux → All
Hardware: x86 → All
Whiteboard: [no l10n impact][needs review mkmelin][needs superreview bienvenu] → [no l10n impact][ready to land]
Target Milestone: --- → Thunderbird 3.0rc1
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 4•15 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/c883626d8065
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [no l10n impact][ready to land] → [no l10n impact]
You need to log in
before you can comment on or make changes to this bug.
Description
•