518395 - Drop down menus are rendering with white text instead of black, and are unreadable

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Michael]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20090923 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20090923 Minefield/3.7a1pre

As of the Sept 23rd nightly build, drop down menus are rendering with white text instead of black text.  The text shows up as white on the white and grey OS X menu buttons, and white on white on the actual menu lists.  They are unreadable.

Reproducible: Always

Steps to Reproduce:
1.  Install Sept 23rd nightly minefield build
2.  squint at unreadable menus

Actual Results:  
menus render with white text instead of black

Expected Results:  
menus render with black text instead of white

Comment 1

[Michael]

Attachment: screenshot of white menus

Here is a screenshot of the white menus.  The menus are for this very bug report.

Comment 2

[Shawn Wilsher :sdwilsh]

Very much confirmed.

Comment 3

[[not reading bugmail]]

Did bug 518085 affect this?

Comment 4

[Markus Stange [:mstange]]

Weird. I'm using that nightly and the same Bugzilla theme, but I don't see it. I hope that bug 518085 fixed it; can you retest with the current nightly?

Comment 5

[Shawn Wilsher :sdwilsh]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090923 Minefield/3.7a1pre is the latest (check for updates is saying so at least).

Comment 6

[Markus Stange [:mstange]]

Oh wait, so I'm actually behind. I'm using yesterday's nightly, and then this is a regression from bug 518085.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Seems like it would be nice to have a test to catch this. Not sure how easy
that is to do though.

Comment 8

[Markus Stange [:mstange]]

I'll add tests that compares all platform colors that can't be changed by the user to known-good hardcoded values. These tests might fail with new OS versions, but then we at least know about it.

Comment 9

[Markus Stange [:mstange]]

For the record, I failed in bug 518085 because I compared the colors to Firefox 3.5 instead of to a nightly from last week. The color -moz-comboboxtext has been introduced in 1.9.2 in bug 472772.

Comment 10

[Markus Stange [:mstange]]

Attachment: script that queries system colors

Comment 11

[Markus Stange [:mstange]]

Attachment: fix + test

Comment 12

[Josh Aas]

Comment on attachment 402492 [details] [diff] [review]
fix + test

Did you upload the wrong file?

Comment 13

[Markus Stange [:mstange]]

Attachment: fix + test

Comment 14

[Josh Aas]

Comment on attachment 402510 [details] [diff] [review]
fix + test

As for the test, it's interesting but I could take it or leave it. I'm not sure how useful it is and it seems fragile. If roc likes it then go for it.

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 402510 [details] [diff] [review]
fix + test

roc, do you think this test makes sense?

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 402510 [details] [diff] [review]
fix + test

it's OK

Comment 17

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/de927bfd4351