Closed
Bug 518641
Opened 15 years ago
Closed 15 years ago
"make package-tests" doesn't work right on OS X universal builds
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 beta5-fixed, status1.9.1 .10-fixed)
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta5-fixed |
status1.9.1 | --- | .10-fixed |
People
(Reporter: jrmuizel, Assigned: ted)
References
Details
Attachments
(5 files)
6.79 KB,
patch
|
benjamin
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
2.43 KB,
patch
|
benjamin
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
565 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
4.17 KB,
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
2.28 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
Error 0 (Unknown error: 0).35957 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug427744.html | Should have seen the test plugin
47332 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/generic/test/test_plugin_mouse_coords.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - p1.getLastMouseX is not a function
lastScript86495 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_npobject_getters.html | plugin1.pluginFoundElement (NPNVPluginElementNPObject)
86496 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_npobject_getters.html | window.pluginFoundWindow (NPNVWindowNPObject)
86499 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_pluginstream_asfile.html | Test timed out.
86502 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_pluginstream_asfileonly.html | Test timed out.
86505 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_pluginstream_geturl.html | Test timed out.
86508 ERROR TEST-UNEXPECTED-FAIL | /tests/modules/plugin/test/test_pluginstream_geturlnotify.html | Test timed out.
86509 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up.
86510 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 159 remaining tests.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1253812968.1253815919.30710.gz
Comment 1•15 years ago
|
||
This happened on the newly-introduced opt machines, which run builds without --enable-logrefcnt.
Assignee | ||
Comment 2•15 years ago
|
||
This is probably a packaging or harness error. Note the first error is "Should have seen the test plugin", so somehow the test plugin is not being loaded in these tests. I'm going to move this over to RelEng for investigation, catlee and I will take a look at it.
Component: Plug-ins → Release Engineering
Product: Core → mozilla.org
QA Contact: plugins → release
Version: Trunk → other
Assignee | ||
Comment 3•15 years ago
|
||
I've hidden the OSX opt unittest builds on Firefox-Unittest for the time being.
Assignee | ||
Updated•15 years ago
|
Summary: TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug427744.html | Should have seen the test plugin → TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug427744.html | Should have seen the test plugin on OS X opt unittests
Assignee | ||
Comment 4•15 years ago
|
||
$ file bin/plugins/Test.plugin/Contents/MacOS/libnptest.dylib
bin/plugins/Test.plugin/Contents/MacOS/libnptest.dylib: Mach-O dynamically linked shared library ppc
Yeah, that'd be our problem. I guess the test packages just don't currently work right on universal builds. The test plugin that's being packaged is PPC, which clearly doesn't work. On a related note, everything in bin/ is also ppc, including xpcshell. I guess this works because they'll get run in Rosetta (which is kind of insane), and libxul and everything are universal binaries, so that works, but an x86 Firefox trying to load a PPC plugin fails.
Assignee | ||
Comment 5•15 years ago
|
||
Going to have to make 'make package-tests' have a special case for universal builds, just like 'make package'.
Assignee: nobody → ted.mielczarek
Component: Release Engineering → Build Config
Product: mozilla.org → Core
QA Contact: release → build-config
Version: other → Trunk
Assignee | ||
Updated•15 years ago
|
Summary: TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug427744.html | Should have seen the test plugin on OS X opt unittests → "make package-tests" doesn't work right on OS X universal builds
Assignee | ||
Comment 6•15 years ago
|
||
I had to fix this first. The unify script currently chokes on Java .class files, which we apparently have hiding in our test suites somewhere. The reason is that Mach-O fat binaries and Java .class files use the same magic number, and unify detects fat binaries by magic number. This patch fixes unify, and adds some basic unit tests of this behavior.
Attachment #403252 -
Flags: review?(benjamin)
Assignee | ||
Comment 7•15 years ago
|
||
This makes the universal postflight makefile build arch-specific test packages, and then unify them to dist/universal/test-package-stage, very similar to what we do with the app package. It then adds some special-casing to the "make package-tests" target, such that universal builds will just package up the bits that we staged in the postflight makefile.
This produces a plausible-looking test package, with universal binaries. I haven't tried actually running tests on it yet, nor have I tried running "package-tests" on a non-universal build with this patch yet.
Attachment #403255 -
Flags: review?(benjamin)
Assignee | ||
Comment 8•15 years ago
|
||
Some basic testing of the packaged build + test package show that the tests mentioned in comment 0 pass.
Updated•15 years ago
|
Attachment #403252 -
Flags: review?(benjamin) → review+
Updated•15 years ago
|
Attachment #403255 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 9•15 years ago
|
||
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/5642cd4a7e88
http://hg.mozilla.org/mozilla-central/rev/07837dc569c6
Hopefully this should make the OS X opt unittest runs go green, and we can un-hide them!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•15 years ago
|
||
jhford hit bustage on a XULRunner universal build. This needs a followup to move the two cp lines here inside the if:
http://mxr.mozilla.org/mozilla-central/source/build/macosx/universal/flight.mk#118
Comment 11•15 years ago
|
||
The second time a builder tries to unify the packaged tests it fails with
/builds/moz2_slave/mozilla-central-macosx/build/build/macosx/universal/unify: makeUniversal: mkdir: File exists for:
obj-firefox/ppc/dist/universal/test-package-stage
Three builds have failed like this now, eg
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1254357655.1254360964.4557.gz
flight.mk has a rm -f for the universal app at
http://hg.mozilla.org/mozilla-central/file/07837dc569c6/build/macosx/universal/flight.mk#l106
but there's no equivalent for packaged tests.
Comment 12•15 years ago
|
||
Attachment #403952 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 13•15 years ago
|
||
Comment on attachment 403952 [details] [diff] [review]
Step 3. Followup for bustage during 2nd build
Thanks, I noticed that yesterday but didn't have time to fix it. (Along with comment 10.)
Attachment #403952 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 14•15 years ago
|
||
Pushed another bustage fix followup:
http://hg.mozilla.org/mozilla-central/rev/ab3ee8fc063d
Assignee | ||
Updated•15 years ago
|
Assignee | ||
Comment 15•15 years ago
|
||
Comment on attachment 403252 [details] [diff] [review]
Step 1: fix unify to not choke on Java .class files
We need these patches on 1.9.2 in order to enable unit tests on nightly and release builds for OS X. This patch touches some build machinery, but also has unit tests. Should have no impact on the bits we ship.
Attachment #403252 -
Flags: approval1.9.2?
Assignee | ||
Comment 16•15 years ago
|
||
Comment on attachment 403255 [details] [diff] [review]
Step 2: unify test packages in postflight makefile
We need these patches on 1.9.2 in order to enable unit tests on nightly and release builds for OS X. This patch touches some build machinery, but only in ways that involve the test package. Should have no impact on the bits we ship.
Attachment #403255 -
Flags: approval1.9.2?
Comment 17•15 years ago
|
||
Comment on attachment 403252 [details] [diff] [review]
Step 1: fix unify to not choke on Java .class files
a192=beltzner, would prefer if you could land in the morning EST so if it causes problems you can back it out before the PSTers get up.
Attachment #403252 -
Flags: approval1.9.2? → approval1.9.2+
Comment 18•15 years ago
|
||
Comment on attachment 403255 [details] [diff] [review]
Step 2: unify test packages in postflight makefile
a192=beltzner, would prefer if you could land in the morning EST so if it causes problems you can back it out before the PSTers get up.
Attachment #403255 -
Flags: approval1.9.2? → approval1.9.2+
Assignee | ||
Comment 19•15 years ago
|
||
Pushed to 1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7c4620338422
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c0b78865c85e
(the latter changeset is a rollup of the "Step 2" patch, the "Step 3" patch, and the bustage fix from comment 14).
status1.9.2:
--- → final-fixed
Updated•15 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
Comment 20•15 years ago
|
||
Attachment #429398 -
Flags: review?(ted.mielczarek)
Comment 21•15 years ago
|
||
Attachment #429399 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 22•15 years ago
|
||
Comment on attachment 429398 [details] [diff] [review]
(Dv1) flight.mk: formatting nits
Really, I don't care.
Attachment #429398 -
Flags: review?(ted.mielczarek) → review-
Updated•15 years ago
|
Attachment #429399 -
Flags: review?(bugspam.Callek) → review+
Comment 23•15 years ago
|
||
Comment on attachment 429399 [details] [diff] [review]
(Ev1-CC) Port it to comm-central
[Checkin: Comment 23]
http://hg.mozilla.org/comm-central/rev/e8064a410e5b
Attachment #429399 -
Attachment description: (Ev1-CC) Port it to comm-central → (Ev1-CC) Port it to comm-central
[Checkin: Comment 23]
Updated•15 years ago
|
Blocks: C192ConfSync
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•