518806 - make getpersonas.com deliver lightweight themes to Firefox 3.6

Status: VERIFIED FIXED

(Websites Graveyard :: getpersonas.com, defect, P1)

Description

[Dão Gottwald [:dao]]

Firefox 3.6 will support the following events:

InstallBrowserTheme (formerly SelectPersona)
PreviewBrowserTheme (formerly PreviewPersona)
ResetBrowserThemePreview (formerly ResetPersona)

The attribute that contains the JSON data is called "data-browsertheme" (formerly "persona").

Attachment 399709 [details] is an example for that.

Comment 1

[Dão Gottwald [:dao]]

A note on why I chose different terms... Apart from my obvious attempt to use "theme" rather than "persona" consistently, the "data-" prefix makes the attribute valid HTML5.

Comment 2

[[not reading bugmail]]

(In reply to comment #0)

> Attachment 399709 [details] is an example for that.

Verified attachment example works with latest trunk.

Comment 3

[Ryan Doherty (:rdoherty)]

wfm, but we'll still keep the previous events and attributes to support the Personas add-on.

Comment 4

[Johnathan Nightingale [:johnath]]

We need to get this in for the Firefox 3.6 beta, so that testers can exercise the feature, but I have no flags to mark it with.

Ryan, is it likely to take a long time to get this live? Beta code freeze is targeted for this week.

Comment 5

[Johnathan Nightingale [:johnath]]

Ah - beltzner just added the flag to this component. Flagging blocking, P1. Sorry to pounce, Ryan - I would have marked this sooner if I had a mechanism.

Comment 6

[Ryan Doherty (:rdoherty)]

(In reply to comment #4)
> Ryan, is it likely to take a long time to get this live? Beta code freeze is
> targeted for this week.

I can get it up on staging by eod today (http://sm-personas01.mozilla.org/). getpersonas.com has a push tuesday night (7/29) which it can be bundled with.

Comment 7

[Johnathan Nightingale [:johnath]]

Awesome - thanks for the quick response.

Comment 8

[Ryan Doherty (:rdoherty)]

Will 3.6 still have the 'CheckPersonas' event available? I use some detection to tell if Firefox has Personas installed and need that to set the 'Wear this' buttons appropriately (and call the correct events).

Comment 9

[Ryan Doherty (:rdoherty)]

(In reply to comment #8)
> Will 3.6 still have the 'CheckPersonas' event available? I use some detection
> to tell if Firefox has Personas installed and need that to set the 'Wear this'
> buttons appropriately (and call the correct events).

Actually, nvm. I can sniff for 3.6.

Comment 10

[Johnathan Nightingale [:johnath]]

(In reply to comment #9)
> Actually, nvm. I can sniff for 3.6.

(and up.  :)

Comment 11

[Ryan Doherty (:rdoherty)]

r52457 adds new events on top of old Personas events. Should be on stage in about ~10 mins. Push to prod is scheduled for tmrw evening.

Comment 12

[Johnathan Nightingale [:johnath]]

Looks great - we will have to figure out the rest of it (whether to offer personas as an addon for 3.6/3.7 users in quite so prominent a way, whether we should change the copy to reflect the fact that support is built in) but that's all separate bugs. It'll be great to have this in production, thanks again for the quick turnaround, Ryan.

Comment 13

[Ryan Doherty (:rdoherty)]

No problem :)

I did just notice that the preview events aren't working (3.6b1pre). Do I need a nightly?

Comment 14

[Johnathan Nightingale [:johnath]]

You'll need a reasonably recent nightly to have any support, but if install is working and preview isn't, it's because "sm-personas01.mozilla.org" isn't on the default-trusted list (only getpersonas.com and addons.mozilla.org are).

To trust sm-personas01.mozilla.org
1) Go to the front page
2) Page Info->Permissions
3) Uncheck Use Default for "Install Extensions and Themes", instead always allow.

Comment 15

[Ryan Doherty (:rdoherty)]

Thanks, that worked!

Comment 16

[Johnathan Nightingale [:johnath]]

(In reply to comment #11)
> r52457 adds new events on top of old Personas events. Should be on stage in
> about ~10 mins. Push to prod is scheduled for tmrw evening.

Looks like it's gone live - everything working as advertised, thanks Ryan!

Comment 17

[Ryan Doherty (:rdoherty)]

So we're planning on moving images from getpersonas.com to a CDN (bug 519851). Can 3.6 handle loading images from a different domain (personas-cdn.mozilla.net for example)?

Comment 18

[Dão Gottwald [:dao]]

(In reply to comment #17)
> So we're planning on moving images from getpersonas.com to a CDN (bug 519851).
> Can 3.6 handle loading images from a different domain (personas-cdn.mozilla.net
> for example)?

yes

Comment 19

[Ryan Doherty (:rdoherty)]

Right now getpersonas.com adds a lot of extra data in the JSON blob:

name
accentcolor
textcolor
header
footer
category
description
author
detailURL
headerURL
footerURL
previewURL
iconURL

I'm planning on removing all but the 6 used in attachment 399709 [details]. Are there any that are actually necessary?

Comment 20

[Dão Gottwald [:dao]]

See lines 7207-7209: http://hg.mozilla.org/mozilla-central/annotate/7a11da3c6a06/browser/base/content/browser.js#l7207
The personas extension might use additional data like 'category' or different key names like 'header' instead of 'headerURL'.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; this is well-tested, now.